From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755152Ab3CGIlL (ORCPT ); Thu, 7 Mar 2013 03:41:11 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:17318 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132Ab3CGIlK (ORCPT ); Thu, 7 Mar 2013 03:41:10 -0500 Message-ID: <51385291.9060109@huawei.com> Date: Thu, 7 Mar 2013 16:40:49 +0800 From: "zhangwei(Jovi)" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Andrew Morton CC: "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Jiri Slaby Subject: Re: [PATCH] sysrq: allow user trigger sysrq by upper-case character key References: <5136C106.40308@huawei.com> <20130306133921.62b9cc38beca2145269c0182@linux-foundation.org> In-Reply-To: <20130306133921.62b9cc38beca2145269c0182@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.66.58.241] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2013/3/7 5:39, Andrew Morton wrote: > On Wed, 6 Mar 2013 12:07:34 +0800 "zhangwei(Jovi)" wrote: > >> See the help text output of /proc/sysrq-trigger: >> >> SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) >> memory-full-oom-kill(F) kill-all-tasks(I) ... >> >> Most command is referenced by responding upper-case character, >> this would hint user can trigger sysrq by upper-case character key, >> but that's wrong, sysrq only accept lower-case character currently. >> >> It's reasonable to let user trigger sysrq by upper-case character key. >> >> Signed-off-by: zhnagwei(Jovi) >> --- >> drivers/tty/sysrq.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c >> index 3687f0c..a88908e 100644 >> --- a/drivers/tty/sysrq.c >> +++ b/drivers/tty/sysrq.c >> @@ -471,6 +471,8 @@ static int sysrq_key_table_key2index(int key) >> retval = key - '0'; >> else if ((key >= 'a') && (key <= 'z')) >> retval = key + 10 - 'a'; >> + else if ((key >= 'A') && (key <= 'Z')) >> + retval = key + 10 - 'A'; >> else >> retval = -1; >> return retval; > > Then fix the help message ;) > > We're already using 19 of the 26 letters and this change would rule out > future use of the 26 upper-case letters. > > I doubt if anyone is hurting from the inconsistent help message, really. It's confusing, I always try to trigger sysrq by upper-case character after read help message. I will resend patch to change the help message instead. Thanks. >