From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: [PATCH Resend 0/8] sysrq: fix inconstistent help message of sysrq key
Date: Thu, 7 Mar 2013 16:59:37 +0800 [thread overview]
Message-ID: <513856F9.1070509@huawei.com> (raw)
(v1->v2: change the help message of sysrq key, instead of allow user trigger upper-case character)
Currently help message of /proc/sysrq-trigger highlight its
upper-case characters, like below:
SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
memory-full-oom-kill(F) kill-all-tasks(I) ...
this would confuse user trigger sysrq by upper-case character, which is
inconsistent with the real lower-case character registed key.
This inconsistent help message will also lead more confused when
26 upper-case letters put into use in future.
This series fix it.
Thanks the comments from Andrew and Randy.
---
Documentation/sysrq.txt | 20 ++++++++---------
arch/arm/kernel/etm.c | 2 +-
arch/powerpc/xmon/xmon.c | 2 +-
arch/sparc/kernel/process_64.c | 4 ++--
drivers/net/ethernet/ibm/emac/debug.c | 2 +-
drivers/tty/sysrq.c | 38 ++++++++++++++++-----------------
kernel/debug/debug_core.c | 2 +-
kernel/power/poweroff.c | 2 +-
8 files changed, 36 insertions(+), 36 deletions(-)
reply other threads:[~2013-03-07 9:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513856F9.1070509@huawei.com \
--to=jovi.zhangwei@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox