From: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API
Date: Fri, 08 Mar 2013 16:32:25 +0900 [thread overview]
Message-ID: <51399409.4090207@hitachi.com> (raw)
In-Reply-To: <20130307153442.755353831@goodmis.org>
Steven,
(03/08/2013 12:34 AM), Steven Rostedt wrote:
> The second patch, returns success on a reset of the buffer even if
> the buffer wasn't allocated. Returning -EINVAL is just confusing.
I realized we should update the snapshot documentation together with
this change.
I attached a patch to update the documentation. Could you include this
patch?
Thanks,
Hiraku Toyooka
From: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
Subject: [PATCH] tracing: update documentation of snapshot utility
Now, "snapshot" file returns success on a reset of snapshot buffer
even if the buffer wasn't allocated, instead of returning EINVAL.
This patch updates snapshot desctiption according to the change.
Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
---
Documentation/trace/ftrace.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/trace/ftrace.txt b/Documentation/trace/ftrace.txt
index 53d6a3c..a372304 100644
--- a/Documentation/trace/ftrace.txt
+++ b/Documentation/trace/ftrace.txt
@@ -1873,7 +1873,7 @@ feature:
status\input | 0 | 1 | else |
--------------+------------+------------+------------+
- not allocated |(do nothing)| alloc+swap | EINVAL |
+ not allocated |(do nothing)| alloc+swap |(do nothing)|
--------------+------------+------------+------------+
allocated | free | swap | clear |
--------------+------------+------------+------------+
--
1.7.11.7
next prev parent reply other threads:[~2013-03-08 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 15:34 [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API Steven Rostedt
2013-03-07 15:34 ` [PATCH 1/2] tracing: Add help of snapshot feature when snapshot is empty Steven Rostedt
2013-03-07 15:34 ` [PATCH 2/2] tracing: Do not return EINVAL in snapshot when not allocated Steven Rostedt
2013-03-08 7:32 ` Hiraku Toyooka [this message]
2013-03-08 13:17 ` [PATCH 0/2] [GIT PULL][3.9] tracing: Fix in snapshot API Ingo Molnar
2013-03-08 15:05 ` [tip:perf/urgent] tracing: update documentation of snapshot utility tip-bot for Hiraku Toyooka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51399409.4090207@hitachi.com \
--to=hiraku.toyooka.gu@hitachi.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox