From: Jiri Slaby <jslaby@suse.cz>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 8250.nr_uarts broken in 3.7
Date: Fri, 08 Mar 2013 23:58:39 +0100 [thread overview]
Message-ID: <513A6D1F.5000202@suse.cz> (raw)
In-Reply-To: <20130308224950.GM13719@hansolo.jdub.homelinux.org>
On 03/08/2013 11:49 PM, Josh Boyer wrote:
> On Fri, Mar 08, 2013 at 11:47:01PM +0100, Jiri Slaby wrote:
>> Yeah, I agree this is ugly. Just re-definining MODULE_PARAM_PREFIX at
>> the end of the file should do the trick (followed by
>> "module_param(nr_uarts, uint, 0644)").
>
> For some reason, I thought I had tried that. Maybe I didn't. I'll look
> into it again.
I see. Because we would re-define some global variables. What if we put
module_param into a function?
--
js
suse labs
next prev parent reply other threads:[~2013-03-08 22:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 18:56 8250.nr_uarts broken in 3.7 Josh Boyer
2013-03-07 18:58 ` Josh Boyer
2013-03-07 19:07 ` Jiri Slaby
2013-03-07 19:10 ` Josh Boyer
2013-03-07 21:14 ` Josh Boyer
2013-03-07 23:12 ` Greg Kroah-Hartman
2013-03-08 1:01 ` Josh Boyer
2013-03-08 1:39 ` Greg Kroah-Hartman
2013-03-08 21:27 ` Josh Boyer
2013-03-08 22:47 ` Jiri Slaby
2013-03-08 22:49 ` Josh Boyer
2013-03-08 22:58 ` Jiri Slaby [this message]
2013-03-08 23:10 ` Jiri Slaby
2013-03-08 23:14 ` Jiri Slaby
2013-03-08 23:28 ` Josh Boyer
2013-03-08 23:44 ` Josh Boyer
2013-03-09 9:14 ` Jiri Slaby
2013-03-09 13:30 ` Josh Boyer
2013-03-09 14:14 ` Jiri Slaby
2013-03-09 17:02 ` Josh Boyer
2013-03-10 14:33 ` [PATCH v2] serial: 8250: Keep 8250.<xxxx> module options functional after driver rename Josh Boyer
2013-03-10 22:33 ` Jiri Slaby
2013-03-10 12:21 ` 8250.nr_uarts broken in 3.7 Sean Young
2013-03-08 23:11 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513A6D1F.5000202@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox