Re: Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2013/03/08 22:15), oskar.andero@sonymobile.com wrote:
> On 05:23 Fri 08 Mar     , Masami Hiramatsu wrote:
>> (2013/03/07 19:44), oskar.andero@sonymobile.com wrote:
>>> From: Bjorn Davidsson <bjorn.davidsson@sonymobile.com>
>>>
>>> The kprobes blacklist contains x86-specific symbols.
>>> Looking for these in kallsyms takes unnecessary time
>>> during startup on non-X86 platform.
>>> Added #ifdef CONFIG_X86 around them.
>>
>> Right. however, it might be better break that into
>> common and arch-specific lists, because there may be
>> other arch-specific non-probe-able functions on each
>> architecture...
> 
> Ok. You mean adding, for instance, a kprobe_blacklist_arch[] in arch/x86
> somewhere or did you have something else in mind? I guess we preferably want
> to get rid of the #ifdef.

Yes, we can have symbol tables (const char *arch_kprobes_blacksyms[],
common_kprobes_blacksyms[]) to list it up, and when initializing
the blacklist table, we can check whether kprobes_blacklist == NULL
and initialize it.

Thank you,

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com