From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Chuansheng Liu <chuansheng.liu@intel.com>
Cc: lenb@kernel.org, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] intel_idle: changing the continue to break in intel_idle_cpu_init()
Date: Sat, 09 Mar 2013 04:01:06 +0100 [thread overview]
Message-ID: <513AA5F2.1000909@linaro.org> (raw)
In-Reply-To: <1362755024.31506.44.camel@cliu38-desktop-build>
On 03/08/2013 04:03 PM, Chuansheng Liu wrote:
>
> According to commit e022e7eb9, the .enter == NULL is the last one in
> state_tables[].
>
> So just like intel_idle_cpuidle_driver_init(), in case of .enter == NULL,
> breaking the for(;;) loop directly.
>
> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
> ---
Sounds good.
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> drivers/idle/intel_idle.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 5d66750..17c9cf9 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -610,7 +610,7 @@ static int intel_idle_cpu_init(int cpu)
> int num_substates, mwait_hint, mwait_cstate, mwait_substate;
>
> if (cpuidle_state_table[cstate].enter == NULL)
> - continue;
> + break;
>
> if (cstate + 1 > max_cstate) {
> printk(PREFIX "max_cstate %d reached\n", max_cstate);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-03-09 3:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 16:42 [PATCH] intel_idle: set the state_tables array into __initdata to save mem Chuansheng Liu
2013-03-07 9:49 ` Daniel Lezcano
2013-03-08 0:44 ` Liu, Chuansheng
2013-03-08 15:02 ` [PATCH 0/3] " Chuansheng Liu
2013-03-08 15:03 ` [PATCH 1/3] intel_idle: changing the continue to break in intel_idle_cpu_init() Chuansheng Liu
2013-03-09 3:01 ` Daniel Lezcano [this message]
2013-03-08 15:04 ` [PATCH 2/3] intel_idle: Removing the redundant calculating for dev->state_count Chuansheng Liu
2013-03-09 3:00 ` Daniel Lezcano
2013-03-11 1:29 ` Liu, Chuansheng
2013-03-11 10:44 ` [PATCH 2/3 V2] " Chuansheng Liu
2013-03-11 9:08 ` Daniel Lezcano
2013-03-08 15:06 ` [PATCH 3/3] intel_idle: set the state_tables array as __initdata to save mem Chuansheng Liu
2013-03-09 3:01 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513AA5F2.1000909@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=chuansheng.liu@intel.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox