Re: 8250.nr_uarts broken in 3.7

Sean Young
2013-03-10T12:21:27Z

On Sat, Mar 09, 2013 at 03:14:18PM +0100, Jiri Slaby wrote:
> This is so disgusting that I will do the following:
> * ack your patch after you change the above (if that works)
> * rename 8250.c to 8250_core.c
> * change 8250_core.ko back to 8250.ko (ie. bring back the old module name)
> * thus switch MODULE_PARAM_PREFIX above to "8250_core."
> * deprecate all the newly added 8250_core.* params somehow and schedule
> for removal. IMO this warrants a kernel config option like
> CONFIG_8250_DEPRECATED_MODULE_PARAMS.
>
> We have a lesson learned.

Indeed. In the patch that broke things, I renamed the module rather than
the 8250.c source file in order to keep the patch small, but obviously
did not consider the consequences well enough. I'm sorry about the mess
I created.

Sean