* [PATCH] ARM:kernel: beautify code, rel->r_offset is __u32 which never < 0
@ 2013-03-10 1:51 Chen Gang
0 siblings, 0 replies; only message in thread
From: Chen Gang @ 2013-03-10 1:51 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
rel->r_offset is __u32 which never < 0.
it is defined in uapi/linux/elf.h
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/kernel/module.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c
index 1e9be5d..386086e 100644
--- a/arch/arm/kernel/module.c
+++ b/arch/arm/kernel/module.c
@@ -74,7 +74,7 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex,
sym = ((Elf32_Sym *)symsec->sh_addr) + offset;
symname = strtab + sym->st_name;
- if (rel->r_offset < 0 || rel->r_offset > dstsec->sh_size - sizeof(u32)) {
+ if (rel->r_offset > dstsec->sh_size - sizeof(u32)) {
pr_err("%s: section %u reloc %u sym '%s': out of bounds relocation, offset %d size %u\n",
module->name, relindex, i, symname,
rel->r_offset, dstsec->sh_size);
--
1.7.7.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-03-10 1:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 1:51 [PATCH] ARM:kernel: beautify code, rel->r_offset is __u32 which never < 0 Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox