Re: [PATCHSET wq/for-3.10-tmp] workqueue: implement workqueue with custom worker attributes

Lai Jiangshan
2013-03-11T15:42:30Z

On Sun, Mar 10, 2013 at 8:01 PM, Tejun Heo <tj@kernel.org> wrote:
> Hey, Lai.
>
> On Sun, Mar 10, 2013 at 06:34:33PM +0800, Lai Jiangshan wrote:
>> > This patchset contains the following 31 patches.
>> >
>> > 0001-workqueue-make-sanity-checks-less-punshing-using-WAR.patch
>>
>> > 0002-workqueue-make-workqueue_lock-irq-safe.patch
>>
>> workqueue_lock protects too many things. We can introduce different locks
>> for different purpose later.
>
> I don't know. My general attitude toward locking is the simpler the
> better. None of the paths protected by workqueue_lock are hot.
> There's no actual benefit in making them finer grained.
>
>> > 0023-workqueue-implement-get-put_pwq.patch
>>
>> I guess this patch and patch25 may have very deep issue VS RCU.
>
> Hmmm... scary. I suppose you're gonna elaborate on the review of the
> actual patch?
>
>> > 0024-workqueue-prepare-flush_workqueue-for-dynamic-creati.patch
>> > 0025-workqueue-perform-non-reentrancy-test-when-queueing-.patch
>> > 0026-workqueue-implement-apply_workqueue_attrs.patch
>> > 0027-workqueue-make-it-clear-that-WQ_DRAINING-is-an-inter.patch
>> > 0028-workqueue-reject-increasing-max_active-for-ordered-w.patch
>> > 0029-cpumask-implement-cpumask_parse.patch
>> > 0030-driver-base-implement-subsys_virtual_register.patch
>> > 0031-workqueue-implement-sysfs-interface-for-workqueues.patch
>>
>>
>> for 1~13,15~22,26~28, please add Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>

OK, Also add my Reviewed-by to 23~25.

>
> Done.
>

I didn't see you updated branch in your tree.

Thanks,
Lai

> Thanks.
>
> --
> tejun
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/