Re: [PATCH 17/31] workqueue: implement attribute-based unbound worker_pool management

Tejun Heo
2013-03-10T18:36:59Z

On Sun, Mar 10, 2013 at 05:58:21AM -0700, Tejun Heo wrote:
> > > + if (WARN_ON(pool->nr_workers != pool->nr_idle))
> > > + return;
> >
> > This can be false-negative. we should remove this WARN_ON().
>
> How would the test fail spuriously? Can you please elaborate?

I got it. It'll be short by one if there's an active manager.
Removed.

Thanks.

--
tejun