Re: [PATCH v2 16/31] workqueue: introduce workqueue_attrs

Tejun Heo
2013-03-05T22:33:33Z

Hello, Ryan.

On Wed, Mar 06, 2013 at 09:29:35AM +1100, Ryan Mallon wrote:
> > @@ -148,6 +148,8 @@ struct worker_pool {
> > struct mutex assoc_mutex; /* protect POOL_DISASSOCIATED */
> > struct ida worker_ida; /* L: for worker IDs */
> >
> > + struct workqueue_attrs *attrs; /* I: worker attributes */
>
> If attrs always exists, why not just embed the struct and avoid the
> need to alloc/free it?

Because then it'll need a separate init paths for embedded ones. If
the field was in any way hot, I'd have embedded it but it isn't and
it's just less code to share the alloc path.

Thanks.

--
tejun