From: Clemens Ladisch <clemens@ladisch.de>
To: Vicentiu Ciorbaru <cvicentiu@gmail.com>
Cc: perex@perex.cz, tiwai@suse.de, wfp5p@virginia.edu,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] emu10k1: Fix coccicheck warning
Date: Sun, 10 Mar 2013 17:32:07 +0100 [thread overview]
Message-ID: <513CB587.5010304@ladisch.de> (raw)
In-Reply-To: <1362919067-17250-1-git-send-email-cvicentiu@gmail.com>
Vicentiu Ciorbaru wrote:
> Removed redundant cast of kmalloc return pointer.
> - (icode->gpr_map = (u_int32_t __user *)
> - kcalloc(512 + 256 + 256 + 2 * 1024, sizeof(u_int32_t),
> - GFP_KERNEL)) == NULL ||
> + (icode->gpr_map = kcalloc(512 + 256 + 256 + 2 * 1024,
> + sizeof(u_int32_t), GFP_KERNEL)) == NULL ||
Why would casting to __user be redundant?
Regards,
Clemens
next prev parent reply other threads:[~2013-03-10 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 12:37 [PATCH] emu10k1: Fix coccicheck warning Vicentiu Ciorbaru
2013-03-10 16:32 ` Clemens Ladisch [this message]
[not found] ` <CACzaYTOE=tVst3=TvUCtxpMuUOtJiHQ3o2wbgWeMvxwZy41DMw@mail.gmail.com>
2013-03-10 19:49 ` Clemens Ladisch
2013-03-10 19:59 ` Vicentiu Ciorbaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513CB587.5010304@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=cvicentiu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox