public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>
Subject: [PATCH 09/13] tracing: use trace_seq_init to initize seq field in trace_iterator
Date: Mon, 11 Mar 2013 15:14:09 +0800	[thread overview]
Message-ID: <513D8441.7050807@huawei.com> (raw)

the size of seq field in trace_iterator is more than PAGE_SIZE, so
seq memset is expensive, try to use cheap seq init method: trace_seq_init

Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
---
 kernel/trace/trace.c     |   10 ++++++----
 kernel/trace/trace_kdb.c |    5 +++--
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 4cec7b8..c7cc915 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3551,9 +3551,10 @@ waitagain:
 		cnt = PAGE_SIZE - 1;

 	/* reset all but tr, trace, and overruns */
-	memset(&iter->seq, 0,
+	trace_seq_init(&iter->seq);
+	memset(&iter->ent, 0,
 	       sizeof(struct trace_iterator) -
-	       offsetof(struct trace_iterator, seq));
+	       offsetof(struct trace_iterator, ent));
 	iter->pos = -1;

 	trace_event_read_lock();
@@ -5167,9 +5168,10 @@ __ftrace_dump(bool disable_tracing, enum ftrace_dump_mode oops_dump_mode)
 		cnt++;

 		/* reset all but tr, trace, and overruns */
-		memset(&iter.seq, 0,
+		trace_seq_init(&iter.seq);
+		memset(&iter.ent, 0,
 		       sizeof(struct trace_iterator) -
-		       offsetof(struct trace_iterator, seq));
+		       offsetof(struct trace_iterator, ent));
 		iter.iter_flags |= TRACE_FILE_LAT_FMT;
 		iter.pos = -1;

diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c
index 6489b2e..84f1584 100644
--- a/kernel/trace/trace_kdb.c
+++ b/kernel/trace/trace_kdb.c
@@ -37,9 +37,10 @@ static void ftrace_dump_buf(int skip_lines, long cpu_file)
 	kdb_printf("Dumping ftrace buffer:\n");

 	/* reset all but tr, trace, and overruns */
-	memset(&iter.seq, 0,
+	trace_seq_init(&iter.seq);
+	memset(&iter.ent, 0,
 		   sizeof(struct trace_iterator) -
-		   offsetof(struct trace_iterator, seq));
+		   offsetof(struct trace_iterator, ent));
 	iter.iter_flags |= TRACE_FILE_LAT_FMT;
 	iter.pos = -1;

-- 
1.7.9.7



             reply	other threads:[~2013-03-11  7:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11  7:14 zhangwei(Jovi) [this message]
2013-03-11 14:13 ` [PATCH 09/13] tracing: use trace_seq_init to initize seq field in trace_iterator Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513D8441.7050807@huawei.com \
    --to=jovi.zhangwei@huawei.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox