* [PATCH 12/13] scsi/tracing: include correct header file
@ 2013-03-11 7:14 zhangwei(Jovi)
2013-03-11 14:21 ` Steven Rostedt
0 siblings, 1 reply; 6+ messages in thread
From: zhangwei(Jovi) @ 2013-03-11 7:14 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org, Steven Rostedt,
James E.J. Bottomley
scsi_trace.c just export function scsi_trace_parse_cdb to
event tracing infrastructure, It's not necessary to
include trace/events/scsi.h
Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
---
drivers/scsi/scsi_trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_trace.c b/drivers/scsi/scsi_trace.c
index 2bea4f0..b703256 100644
--- a/drivers/scsi/scsi_trace.c
+++ b/drivers/scsi/scsi_trace.c
@@ -17,7 +17,7 @@
*/
#include <linux/kernel.h>
#include <linux/trace_seq.h>
-#include <trace/events/scsi.h>
+#include <scsi/scsi.h>
#define SERVICE_ACTION16(cdb) (cdb[1] & 0x1f)
#define SERVICE_ACTION32(cdb) ((cdb[8] << 8) | cdb[9])
--
1.7.9.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 12/13] scsi/tracing: include correct header file
2013-03-11 7:14 [PATCH 12/13] scsi/tracing: include correct header file zhangwei(Jovi)
@ 2013-03-11 14:21 ` Steven Rostedt
2013-03-11 15:24 ` James Bottomley
0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2013-03-11 14:21 UTC (permalink / raw)
To: zhangwei(Jovi); +Cc: linux-kernel@vger.kernel.org, James E.J. Bottomley
As you didn't include James in the header patch [0/13], he didn't see
you say:
"Two patches changed compilation on scsi subsystem, it should go through
to
SCSI tree."
In the future, send them as a separate patch series. There's no
dependencies on these patches with the rest of the series. They should
have been sent directly to James, with me as the Cc.
-- Steve
On Mon, 2013-03-11 at 15:14 +0800, zhangwei(Jovi) wrote:
> scsi_trace.c just export function scsi_trace_parse_cdb to
> event tracing infrastructure, It's not necessary to
> include trace/events/scsi.h
>
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
> ---
> drivers/scsi/scsi_trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_trace.c b/drivers/scsi/scsi_trace.c
> index 2bea4f0..b703256 100644
> --- a/drivers/scsi/scsi_trace.c
> +++ b/drivers/scsi/scsi_trace.c
> @@ -17,7 +17,7 @@
> */
> #include <linux/kernel.h>
> #include <linux/trace_seq.h>
> -#include <trace/events/scsi.h>
> +#include <scsi/scsi.h>
>
> #define SERVICE_ACTION16(cdb) (cdb[1] & 0x1f)
> #define SERVICE_ACTION32(cdb) ((cdb[8] << 8) | cdb[9])
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 12/13] scsi/tracing: include correct header file
2013-03-11 14:21 ` Steven Rostedt
@ 2013-03-11 15:24 ` James Bottomley
2013-03-11 15:36 ` Steven Rostedt
0 siblings, 1 reply; 6+ messages in thread
From: James Bottomley @ 2013-03-11 15:24 UTC (permalink / raw)
To: Steven Rostedt; +Cc: zhangwei(Jovi), linux-kernel@vger.kernel.org
On Mon, 2013-03-11 at 10:21 -0400, Steven Rostedt wrote:
> As you didn't include James in the header patch [0/13], he didn't see
> you say:
>
> "Two patches changed compilation on scsi subsystem, it should go through
> to
> SCSI tree."
>
> In the future, send them as a separate patch series. There's no
> dependencies on these patches with the rest of the series. They should
> have been sent directly to James, with me as the Cc.
Actually, if you want them applied, they need to go to the SCSI list
<linux-scsi@vger.kernel.org>. It tracks all my pending patches. Stuff
to me personally has a high probability of getting forgotten.
Thanks,
James
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 12/13] scsi/tracing: include correct header file
2013-03-11 15:24 ` James Bottomley
@ 2013-03-11 15:36 ` Steven Rostedt
2013-03-11 15:45 ` Jovi Zhang
0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2013-03-11 15:36 UTC (permalink / raw)
To: James Bottomley; +Cc: zhangwei(Jovi), linux-kernel@vger.kernel.org
On Mon, 2013-03-11 at 15:24 +0000, James Bottomley wrote:
> > In the future, send them as a separate patch series. There's no
> > dependencies on these patches with the rest of the series. They should
> > have been sent directly to James, with me as the Cc.
>
> Actually, if you want them applied, they need to go to the SCSI list
> <linux-scsi@vger.kernel.org>. It tracks all my pending patches. Stuff
> to me personally has a high probability of getting forgotten.
Zhangwei,
As you may be sending patches to other maintainers, please read the
MAINTAINERS file and send appropriate patches in a separate series to
them as directed:
SCSI SUBSYSTEM
M: "James E.J. Bottomley" <JBottomley@parallels.com>
L: linux-scsi@vger.kernel.org
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-pending-2.6.git
S: Maintained
F: drivers/scsi/
F: include/scsi/
Cc the listed maintainers, as well as the listed "L:" lists.
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 12/13] scsi/tracing: include correct header file
2013-03-11 15:36 ` Steven Rostedt
@ 2013-03-11 15:45 ` Jovi Zhang
2013-03-11 15:53 ` Steven Rostedt
0 siblings, 1 reply; 6+ messages in thread
From: Jovi Zhang @ 2013-03-11 15:45 UTC (permalink / raw)
To: Steven Rostedt
Cc: James Bottomley, zhangwei(Jovi), linux-kernel@vger.kernel.org
On Mon, Mar 11, 2013 at 11:36 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 2013-03-11 at 15:24 +0000, James Bottomley wrote:
>
>> > In the future, send them as a separate patch series. There's no
>> > dependencies on these patches with the rest of the series. They should
>> > have been sent directly to James, with me as the Cc.
>>
>> Actually, if you want them applied, they need to go to the SCSI list
>> <linux-scsi@vger.kernel.org>. It tracks all my pending patches. Stuff
>> to me personally has a high probability of getting forgotten.
>
> Zhangwei,
>
> As you may be sending patches to other maintainers, please read the
> MAINTAINERS file and send appropriate patches in a separate series to
> them as directed:
>
> SCSI SUBSYSTEM
> M: "James E.J. Bottomley" <JBottomley@parallels.com>
> L: linux-scsi@vger.kernel.org
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-pending-2.6.git
> S: Maintained
> F: drivers/scsi/
> F: include/scsi/
>
> Cc the listed maintainers, as well as the listed "L:" lists.
>
Thanks, sometimes I forgot cc mailing list in MAINTAINERS file(just
attention on M),
I will got this in next patch submission.
I will resend those two patches with Cc linux-scsi@vger.kernel.org
> -- Steve
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 12/13] scsi/tracing: include correct header file
2013-03-11 15:45 ` Jovi Zhang
@ 2013-03-11 15:53 ` Steven Rostedt
0 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2013-03-11 15:53 UTC (permalink / raw)
To: Jovi Zhang; +Cc: James Bottomley, zhangwei(Jovi), linux-kernel@vger.kernel.org
On Mon, 2013-03-11 at 23:45 +0800, Jovi Zhang wrote:
> Thanks, sometimes I forgot cc mailing list in MAINTAINERS file(just
> attention on M),
> I will got this in next patch submission.
Note, the patches I said were fine, please do not resend. I'll take them
as is.
>
> I will resend those two patches with Cc linux-scsi@vger.kernel.org
Send them as their own patch set. They do not need to be included with
the others.
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-11 15:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11 7:14 [PATCH 12/13] scsi/tracing: include correct header file zhangwei(Jovi)
2013-03-11 14:21 ` Steven Rostedt
2013-03-11 15:24 ` James Bottomley
2013-03-11 15:36 ` Steven Rostedt
2013-03-11 15:45 ` Jovi Zhang
2013-03-11 15:53 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox