public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
	"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power management
Date: Mon, 11 Mar 2013 14:26:40 +0530	[thread overview]
Message-ID: <513D9C48.8090505@nvidia.com> (raw)
In-Reply-To: <20130311085132.GA7900@avionic-0098.mockup.avionic-design.de>

On Monday 11 March 2013 02:21 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Mar 11, 2013 at 02:14:25PM +0530, Laxman Dewangan wrote:
> [...]
>> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
> [...]
>> @@ -431,6 +430,8 @@ static int tegra_rtc_resume(struct platform_device *pdev)
>>   }
>>   #endif
>>   
>> +SIMPLE_DEV_PM_OPS(tegra_rtc_pm_ops, tegra_rtc_suspend, tegra_rtc_resume);
> I should've been more explicit. Since you had this marked as static in
> the previous patch, this needs to be static SIMPLE_DEV_PM_OPS.
Yaah, I should keep the static.

I think I will need to respin this patch only in place of whole series.

Andrew,

Let me know if this is fine.

Thanks,
Laxman


  reply	other threads:[~2013-03-11  8:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11  8:44 [PATCH V2 0/5] rtc: tegra: cleanups to remove warning/code lines Laxman Dewangan
2013-03-11  8:44 ` [PATCH V2 1/5] rtc: tegra: protect suspend/resume callbacks with CONFIG_PM_SLEEP Laxman Dewangan
2013-03-11  8:44 ` [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power management Laxman Dewangan
2013-03-11  8:51   ` Thierry Reding
2013-03-11  8:56     ` Laxman Dewangan [this message]
2013-03-11 17:18       ` Stephen Warren
2013-03-11 17:51         ` Laxman Dewangan
2013-03-11  8:44 ` [PATCH V2 3/5] rtc: tegra: use module_platform_driver_probe for module init/exit Laxman Dewangan
2013-03-11  8:44 ` [PATCH V2 4/5] rtc: tegra: set irq name as device name Laxman Dewangan
2013-03-11  8:44 ` [PATCH V2 5/5] rtc: tegra: use managed rtc_device_register Laxman Dewangan
2013-03-11 17:19 ` [PATCH V2 0/5] rtc: tegra: cleanups to remove warning/code lines Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513D9C48.8090505@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox