From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753444Ab3CKI6d (ORCPT ); Mon, 11 Mar 2013 04:58:33 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:15585 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753279Ab3CKI6c (ORCPT ); Mon, 11 Mar 2013 04:58:32 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 11 Mar 2013 01:52:05 -0700 Message-ID: <513D9C48.8090505@nvidia.com> Date: Mon, 11 Mar 2013 14:26:40 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: Thierry Reding CC: "akpm@linux-foundation.org" , "a.zummo@towertech.it" , "swarren@wwwdotorg.org" , "rtc-linux@googlegroups.com" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power management References: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com> <1362991468-30226-3-git-send-email-ldewangan@nvidia.com> <20130311085132.GA7900@avionic-0098.mockup.avionic-design.de> In-Reply-To: <20130311085132.GA7900@avionic-0098.mockup.avionic-design.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 11 March 2013 02:21 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Mar 11, 2013 at 02:14:25PM +0530, Laxman Dewangan wrote: > [...] >> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c > [...] >> @@ -431,6 +430,8 @@ static int tegra_rtc_resume(struct platform_device *pdev) >> } >> #endif >> >> +SIMPLE_DEV_PM_OPS(tegra_rtc_pm_ops, tegra_rtc_suspend, tegra_rtc_resume); > I should've been more explicit. Since you had this marked as static in > the previous patch, this needs to be static SIMPLE_DEV_PM_OPS. Yaah, I should keep the static. I think I will need to respin this patch only in place of whole series. Andrew, Let me know if this is fine. Thanks, Laxman