From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
pdeschrijver@nvidia.com
Subject: Re: [PATCH V2 2/5] ARM: DT: tegra114: Add i2c controller DT entry
Date: Mon, 11 Mar 2013 11:35:37 -0600 [thread overview]
Message-ID: <513E15E9.8090904@wwwdotorg.org> (raw)
In-Reply-To: <20130310223936.GF4743@avionic-0098.mockup.avionic-design.de>
On 03/10/2013 04:39 PM, Thierry Reding wrote:
> On Sat, Mar 09, 2013 at 11:41:15PM +0530, Laxman Dewangan wrote:
>> NVIDIA's Tegra114 has 5 i2c controllers. These controllers have
>> additional feature/configurations to make it functional over
>> Tegra30's i2c controller driver.
>>
>> Add DT entry for i2c controllers and make it compatible with
>> "nvidia,tegra114-i2c".
>
> Both the subject and description should probably use I2C instead of
> i2c. Also I don't understand what "make it functional over" means.
> Perhaps, since the entries aren't marked compatible with
> nvidia,tegra30-i2c you meant to say that they are incompatible with
> Tegra30?
The second sentence Laxman wrote above should probably say:
These controllers have a modified clocking structure that make them
incompatible with previous hardware.
next prev parent reply other threads:[~2013-03-11 17:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 18:11 [PATCH V2 0/5] ARM: DT: tegra114: Add DT entry for different controller Laxman Dewangan
2013-03-09 18:11 ` [PATCH V2 1/5] ARM: DT: tegra114: add APB DMA controller DT entry Laxman Dewangan
2013-03-10 22:37 ` Thierry Reding
2013-03-09 18:11 ` [PATCH V2 2/5] ARM: DT: tegra114: Add i2c " Laxman Dewangan
2013-03-10 22:39 ` Thierry Reding
2013-03-11 17:35 ` Stephen Warren [this message]
2013-03-11 17:41 ` Stephen Warren
2013-03-09 18:11 ` [PATCH V2 3/5] ARM: DT: tegra114:add aliases and DMA requestor for serial controller Laxman Dewangan
2013-03-10 22:42 ` Thierry Reding
2013-03-11 17:42 ` Stephen Warren
2013-03-11 17:38 ` Stephen Warren
2013-03-09 18:11 ` [PATCH V2 4/5] ARM: DT: tegra114: add KBC controller DT entry Laxman Dewangan
2013-03-11 17:43 ` Stephen Warren
2013-03-11 17:59 ` Laxman Dewangan
2013-03-11 18:47 ` Stephen Warren
2013-03-09 18:11 ` [PATCH V2 5/5] ARM: DT: tegra114: Add spi " Laxman Dewangan
2013-03-10 22:51 ` Thierry Reding
2013-03-11 22:15 ` [PATCH V2 0/5] ARM: DT: tegra114: Add DT entry for different controller Stephen Warren
2013-03-12 10:11 ` Laxman Dewangan
2013-03-12 18:31 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513E15E9.8090904@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox