From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
juhosg@openwrt.org, blogic@openwrt.org, kaloz@openwrt.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: use newly introduced devm_ioremap_resource()
Date: Mon, 11 Mar 2013 22:07:53 +0300 [thread overview]
Message-ID: <513E2B89.40308@cogentembedded.com> (raw)
In-Reply-To: <1363015477-29685-1-git-send-email-silviupopescu1990@gmail.com>
Hello.
On 03/11/2013 06:24 PM, Silviu-Mihai Popescu wrote:
> Convert all uses of devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
>
> devm_ioremap_resource() provides its own error messages so all explicit
> error messages can be removed from the failure code paths.
>
> Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
> ---
> arch/mips/pci/pci-ar71xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
I think the idea was to combine changes to the 2 files in one patch.
Then the subject will truly reflect what it's doing...
WBR, Sergei
prev parent reply other threads:[~2013-03-11 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 15:24 [PATCH] pci: use newly introduced devm_ioremap_resource() Silviu-Mihai Popescu
2013-03-11 17:14 ` Gabor Juhos
2013-03-11 19:07 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513E2B89.40308@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=blogic@openwrt.org \
--cc=juhosg@openwrt.org \
--cc=kaloz@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=silviupopescu1990@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox