Re: [PATCH V2 3/5] ARM: DT: tegra114:add aliases and DMA requestor for serial controller

Stephen Warren
2013-03-11T17:42:52Z

On 03/10/2013 04:42 PM, Thierry Reding wrote:
> On Sat, Mar 09, 2013 at 11:41:16PM +0530, Laxman Dewangan wrote:
> [...]
>> diff --git a/arch/arm/boot/dts/tegra114.dtsi
>> b/arch/arm/boot/dts/tegra114.dtsi
> [...]
>> @@ -99,38 +106,50 @@ 0x70003000 0x40c>; /* Mux registers */ };
>>
>> - serial@70006000 { + /* + * There are two serial driver i.e.
>> 8250 based simple serial + * driver and APB DMA based serial
>> driver for higher baudrate + * and performace. To enable the
>> 8250 based driver, the compatible + * is
>> "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable + *
>> the APB DMA based serial driver, the comptible is + *
>> "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". + */ + uarta:
>> serial@70006000 {
>
> I'm not sure if this is a good place for this comment. Perhaps it
> should go into the binding documentation?

It is at least consistent with previous tegra20/30.dtsi. The two
compatible values are separate bindings, so a clue here re: which one
to go look at isn't a bad idea, although I agree that having each
binding document mention the other one would also be good.