Re: [PATCH V2 2/5] ARM: DT: tegra114: Add i2c controller DT entry

Stephen Warren
2013-03-11T17:35:42Z

On 03/10/2013 04:39 PM, Thierry Reding wrote:
> On Sat, Mar 09, 2013 at 11:41:15PM +0530, Laxman Dewangan wrote:
>> NVIDIA's Tegra114 has 5 i2c controllers. These controllers have
>> additional feature/configurations to make it functional over
>> Tegra30's i2c controller driver.
>>
>> Add DT entry for i2c controllers and make it compatible with
>> "nvidia,tegra114-i2c".
>
> Both the subject and description should probably use I2C instead of
> i2c. Also I don't understand what "make it functional over" means.
> Perhaps, since the entries aren't marked compatible with
> nvidia,tegra30-i2c you meant to say that they are incompatible with
> Tegra30?

The second sentence Laxman wrote above should probably say:

These controllers have a modified clocking structure that make them
incompatible with previous hardware.