From: "H. Peter Anvin" <hpa@zytor.com>
To: Matt Fleming <matt.fleming@intel.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH] efivars: Allow disabling use as a pstore backend
Date: Wed, 13 Mar 2013 10:25:08 -0700 [thread overview]
Message-ID: <5140B674.8070308@zytor.com> (raw)
In-Reply-To: <20130313170724.GB12157@thinkpad-t410>
On 03/13/2013 10:07 AM, Seth Forshee wrote:
>>
>> Granted, this change does mean that your decision at compile time may be
>> final, and you can't enable the pstore code at runtime if you built your
>> kernel/efivars module with CONFIG_EFI_VARS_PSTORE=n. Arguably, I think
>> that's a feature that some people will want, e.g. "Don't allow enabling
>> the efivars pstore backend at all... no, srsly!".
>
> Hmm. Since my original patch was to compile pstore support out
> completely, I interpreted Peter's suggestion to be allowing the user
> override the default even if the default is disabled. That's the
> assumption my implementation was based off of, but maybe I
> misunderstood.
>
> But if Peter agrees with your changes then I'm fine with them too.
>
I think there should be two compile-time options (one to compile in the
EFI pstore code at all, and one to set its default.)
-hpa
next prev parent reply other threads:[~2013-03-13 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 17:40 [PATCH] efivars: Allow disabling use as a pstore backend Seth Forshee
2013-03-07 20:38 ` H. Peter Anvin
2013-03-07 20:59 ` Seth Forshee
2013-03-07 22:15 ` Matt Fleming
2013-03-07 22:17 ` H. Peter Anvin
2013-03-11 21:17 ` Seth Forshee
2013-03-12 19:54 ` Matt Fleming
2013-03-12 21:14 ` Seth Forshee
2013-03-13 15:49 ` Matt Fleming
2013-03-13 17:07 ` Seth Forshee
2013-03-13 17:25 ` H. Peter Anvin [this message]
2013-03-13 18:33 ` Matt Fleming
2013-03-13 19:14 ` Seth Forshee
2013-03-13 19:44 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140B674.8070308@zytor.com \
--to=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matthew.garrett@nebula.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox