From: Lars-Peter Clausen <lars@metafoo.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-iio <linux-iio@vger.kernel.org>,
dan.carpenter@oracle.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-samsung-soc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Naveen Krishna <naveenkrishna.ch@gmail.com>
Subject: Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings
Date: Wed, 13 Mar 2013 19:11:33 +0100 [thread overview]
Message-ID: <5140C155.2070507@metafoo.de> (raw)
In-Reply-To: <CAD=FV=XoE6NCruDUv2UajaP+LWDCp+pgaZJsEKpkoxy3tZNeAw@mail.gmail.com>
On 03/13/2013 07:01 PM, Doug Anderson wrote:
> Naveen,
>
> On Tue, Mar 12, 2013 at 9:48 PM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> Doug, There was a comment from Lars regarding the match not
>> being NULL, if driver depends on CONFIG_OF. So, i've removed
>> the NULL check in v2 of this patch.
>> https://patchwork.kernel.org/patch/2222841/
>>
>> I'm checking the return value of get_version() for -ve values before
>> assigning to info->version. So, i left the (unsigned int) unchanged.
>
> Hmmm, I guess this was the point that confused me. I went back and
> agree with Lars--it can't be NULL. ...but that means that
> exynos_adc_get_version() can't return an error, so why are we checking
> for an error?
Agreed. Adding the dependency on OF in Kconfig should be all that is needed.
- Lars
next prev parent reply other threads:[~2013-03-13 18:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 3:09 [PATCH v2] iio: adc: exynos5_adc: fix compilation warnings Naveen Krishna Chatradhi
2013-03-12 16:14 ` Doug Anderson
2013-03-13 4:48 ` [PATCH v3] " Naveen Krishna Chatradhi
2013-03-13 18:01 ` Doug Anderson
2013-03-13 18:11 ` Lars-Peter Clausen [this message]
2013-03-13 18:23 ` Doug Anderson
2013-03-13 18:35 ` Lars-Peter Clausen
2013-03-13 18:40 ` Lars-Peter Clausen
2013-03-13 20:12 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140C155.2070507@metafoo.de \
--to=lars@metafoo.de \
--cc=ch.naveen@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox