Re: CONFIG_EARLY_PRINTK

Randy Dunlap
2013-03-16T17:38:26Z

On 03/16/13 08:08, Thomas Meyer wrote:
> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>> On 03/13/13 10:15, Thomas Meyer wrote:
>>> Hi,
>>>
>>> -*- Early printk
>>>
>>> help text says:
>>> "You should normally N here, unless you want to debug such a crash.
>>> (Depends on: EXPERT [=n])"
>>>
>>> How to normally N here?
>>
>> You'll have to enable CONFIG_EXPERT and then you can disable EARLY_PRINTK.
>>
>> You may even have to disable CONFIG_EMBEDDED before you can enable
>> CONFIG_EXPERT (I did).
>>
>> Too many hoops to have to jump through. :(
>>
>
> Yes,
>
> so why not do this? As the text to EARLY_PRINTK explains?

Yes, the default should match the help text.
Acked-by: Randy Dunlap <rdunlap@infradead.org>

Please resend your patch with Signed-off-by: line.

Thanks.

>
> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
> index b322f12..d6c2d89 100644
> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
>
> config EARLY_PRINTK
> bool "Early printk" if EXPERT
> - default y
> + default n
> ---help---
> Write kernel log output directly into the VGA buffer or to a
> serial
> port.
>
>
>

--
~Randy