Re: CONFIG_EARLY_PRINTK

Geert Uytterhoeven
2013-03-16T20:10:45Z

On Sat, Mar 16, 2013 at 6:38 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 03/16/13 08:08, Thomas Meyer wrote:
>> Am Mittwoch, den 13.03.2013, 12:56 -0700 schrieb Randy Dunlap:
>>> On 03/13/13 10:15, Thomas Meyer wrote:
>>>> help text says:
>>>> "You should normally N here, unless you want to debug such a crash.
>>>> (Depends on: EXPERT [=n])"
>>>>
>>>> How to normally N here?

>> so why not do this? As the text to EARLY_PRINTK explains?
>
> Yes, the default should match the help text.

So just remove the "default n" line, as "n" is the default.

> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Please resend your patch with Signed-off-by: line.
>
> Thanks.
>
>>
>> diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
>> index b322f12..d6c2d89 100644
>> --- a/arch/x86/Kconfig.debug
>> +++ b/arch/x86/Kconfig.debug
>> @@ -32,7 +32,7 @@ config X86_VERBOSE_BOOTUP
>>
>> config EARLY_PRINTK
>> bool "Early printk" if EXPERT
>> - default y
>> + default n
>> ---help---
>> Write kernel log output directly into the VGA buffer or to a
>> serial
>> port.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds