From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 3/5] ARM: tegra:add aliases and DMA requestor for serial nodes of Tegra114
Date: Wed, 13 Mar 2013 14:02:41 -0600 [thread overview]
Message-ID: <5140DB61.3090809@wwwdotorg.org> (raw)
In-Reply-To: <1363204194-19487-4-git-send-email-ldewangan@nvidia.com>
On 03/13/2013 01:49 PM, Laxman Dewangan wrote:
> Add APB DMA requestor and serial aliases for serial controller.
> There will be two serial driver i.e. 8250 based simple serial driver
> and APB DMA based serial driver for higher baudrate and performace.
>
> The simple serial driver get enabled with compatible "nvidia,tegra114-uart",
> "nvidia,tegra20-uart" and APB DMA based driver will get enabled with
> compatible "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart".
> + /*
> + * There are two serial driver i.e. 8250 based simple serial
> + * driver and APB DMA based serial driver for higher baudrate
> + * and performace. To enable the 8250 based driver, the compatible
> + * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable
> + * the APB DMA based serial driver, the comptible is
> + * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart".
> + */
Again, that text says you want either of:
compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart";
compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart";
(note Tegra20-vs-Tegra30 in the second compatible value)
Why isn't it instead:
compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart";
compatible = "nvidia,tegra114-hsuart", "nvidia,tegra20-hsuart";
(note both second compatible values say Tegra20)
I assume this is a typo.
I suppose I can fix this up when I apply it to avoid a resend, assuming
it's wrong.
next prev parent reply other threads:[~2013-03-13 20:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 19:49 [PATCH V3 0/5] ARM: DT: tegra114: Add DT entry for different controller Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 1/5] ARM: tegra: add APB DMA nodes to Tegra114 DT Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 2/5] ARM: tegra: add i2c " Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 3/5] ARM: tegra:add aliases and DMA requestor for serial nodes of Tegra114 Laxman Dewangan
2013-03-13 20:02 ` Stephen Warren [this message]
2013-03-15 18:26 ` Stephen Warren
2013-03-15 18:42 ` Laxman Dewangan
2013-03-15 18:58 ` Stephen Warren
2013-03-15 19:03 ` Laxman Dewangan
2013-03-15 18:43 ` Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 4/5] ARM: tegra: add KBC nodes to Tegra114 DT Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 5/5] ARM: tegra: add spi " Laxman Dewangan
2013-03-15 18:42 ` Stephen Warren
2013-03-15 18:47 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140DB61.3090809@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox