* [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME
@ 2013-03-14 9:08 Hiroshi Doyu
2013-03-14 20:04 ` Thierry Reding
2013-03-15 5:23 ` Stephen Warren
0 siblings, 2 replies; 4+ messages in thread
From: Hiroshi Doyu @ 2013-03-14 9:08 UTC (permalink / raw)
To: Russell King; +Cc: linux-tegra, Hiroshi Doyu, Stephen Warren, linux-kernel
Make this depend on CONFIG_PM. This protection is necessary to not
cause any build errors with any combination of PM features especially
when supporting a new SoC where each PM features are being enabled
one-by-one during its depelopment.
Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
Reported-by: Joseph Lo <josephl@nvidia.com>
---
drivers/amba/tegra-ahb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c
index 093c435..1f44e56 100644
--- a/drivers/amba/tegra-ahb.c
+++ b/drivers/amba/tegra-ahb.c
@@ -158,7 +158,7 @@ int tegra_ahb_enable_smmu(struct device_node *dn)
EXPORT_SYMBOL(tegra_ahb_enable_smmu);
#endif
-#ifdef CONFIG_PM_SLEEP
+#ifdef CONFIG_PM
static int tegra_ahb_suspend(struct device *dev)
{
int i;
--
1.8.1.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME
2013-03-14 9:08 [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME Hiroshi Doyu
@ 2013-03-14 20:04 ` Thierry Reding
2013-03-15 5:23 ` Stephen Warren
1 sibling, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2013-03-14 20:04 UTC (permalink / raw)
To: Hiroshi Doyu; +Cc: Russell King, linux-tegra, Stephen Warren, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
On Thu, Mar 14, 2013 at 11:08:09AM +0200, Hiroshi Doyu wrote:
> Make this depend on CONFIG_PM. This protection is necessary to not
> cause any build errors with any combination of PM features especially
> when supporting a new SoC where each PM features are being enabled
> one-by-one during its depelopment.
>
> Signed-off-by: Hiroshi Doyu <hdoyu@nvidia.com>
> Reported-by: Joseph Lo <josephl@nvidia.com>
> ---
> drivers/amba/tegra-ahb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c
> index 093c435..1f44e56 100644
> --- a/drivers/amba/tegra-ahb.c
> +++ b/drivers/amba/tegra-ahb.c
> @@ -158,7 +158,7 @@ int tegra_ahb_enable_smmu(struct device_node *dn)
> EXPORT_SYMBOL(tegra_ahb_enable_smmu);
> #endif
>
> -#ifdef CONFIG_PM_SLEEP
> +#ifdef CONFIG_PM
> static int tegra_ahb_suspend(struct device *dev)
> {
> int i;
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME
2013-03-14 9:08 [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME Hiroshi Doyu
2013-03-14 20:04 ` Thierry Reding
@ 2013-03-15 5:23 ` Stephen Warren
2013-03-15 6:56 ` Hiroshi Doyu
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2013-03-15 5:23 UTC (permalink / raw)
To: Hiroshi Doyu; +Cc: Russell King, linux-tegra, linux-kernel
On 03/14/2013 03:08 AM, Hiroshi Doyu wrote:
> Make this depend on CONFIG_PM. This protection is necessary to not
> cause any build errors with any combination of PM features especially
> when supporting a new SoC where each PM features are being enabled
> one-by-one during its depelopment.
Looks fine to me.
Acked-by: Stephen Warren <swarren@nvidia.com>
I assume Russell will want this to go through his patch tracker.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME
2013-03-15 5:23 ` Stephen Warren
@ 2013-03-15 6:56 ` Hiroshi Doyu
0 siblings, 0 replies; 4+ messages in thread
From: Hiroshi Doyu @ 2013-03-15 6:56 UTC (permalink / raw)
To: swarren@wwwdotorg.org
Cc: linux@arm.linux.org.uk, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Stephen Warren <swarren@wwwdotorg.org> wrote @ Fri, 15 Mar 2013 06:23:38 +0100:
> On 03/14/2013 03:08 AM, Hiroshi Doyu wrote:
> > Make this depend on CONFIG_PM. This protection is necessary to not
> > cause any build errors with any combination of PM features especially
> > when supporting a new SoC where each PM features are being enabled
> > one-by-one during its depelopment.
>
> Looks fine to me.
>
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> I assume Russell will want this to go through his patch tracker.
FYI: Patch has been accepted as patch 7675/1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-15 6:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-14 9:08 [PATCH 1/1] amba: tegra-ahb: Fix build error w/ PM_SLEEP w/o PM_RUNTIME Hiroshi Doyu
2013-03-14 20:04 ` Thierry Reding
2013-03-15 5:23 ` Stephen Warren
2013-03-15 6:56 ` Hiroshi Doyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox