* [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon
@ 2013-03-15 8:14 Kumar Amit Mehta
2013-03-15 9:41 ` Ian Abbott
2013-03-15 16:04 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Kumar Amit Mehta @ 2013-03-15 8:14 UTC (permalink / raw)
To: abbotti; +Cc: fmhess, gregkh, hsweeten, devel, kernel-janitors, linux-kernel
fix a missing end-of-statement by adding a semicolon.
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
---
drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
index 279f2cd..37372a1 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -467,7 +467,7 @@ static int ni_atmio_attach(struct comedi_device *dev,
return -EIO;
dev->board_ptr = ni_boards + board;
- boardtype = comedi_board(dev)
+ boardtype = comedi_board(dev);
printk(" %s", boardtype->name);
dev->board_name = boardtype->name;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon
2013-03-15 8:14 [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon Kumar Amit Mehta
@ 2013-03-15 9:41 ` Ian Abbott
2013-03-15 16:03 ` H Hartley Sweeten
2013-03-15 16:04 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Ian Abbott @ 2013-03-15 9:41 UTC (permalink / raw)
To: Kumar Amit Mehta
Cc: Ian Abbott, fmhess@users.sourceforge.net,
gregkh@linuxfoundation.org, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
On 2013-03-15 08:14, Kumar Amit Mehta wrote:
> fix a missing end-of-statement by adding a semicolon.
>
> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index 279f2cd..37372a1 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -467,7 +467,7 @@ static int ni_atmio_attach(struct comedi_device *dev,
> return -EIO;
>
> dev->board_ptr = ni_boards + board;
> - boardtype = comedi_board(dev)
> + boardtype = comedi_board(dev);
>
> printk(" %s", boardtype->name);
> dev->board_name = boardtype->name;
Ironically, that was introduced by a patch titled "staging: comedi:
ni_atmio: fix build errors". :-)
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon
2013-03-15 9:41 ` Ian Abbott
@ 2013-03-15 16:03 ` H Hartley Sweeten
0 siblings, 0 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2013-03-15 16:03 UTC (permalink / raw)
To: Ian Abbott, Kumar Amit Mehta
Cc: Ian Abbott, fmhess@users.sourceforge.net,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
On Friday, March 15, 2013 2:41 AM, Ian Abbott wrote:
> On 2013-03-15 08:14, Kumar Amit Mehta wrote:
>> fix a missing end-of-statement by adding a semicolon.
>>
>> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
>> ---
>> drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
>> index 279f2cd..37372a1 100644
>> --- a/drivers/staging/comedi/drivers/ni_atmio.c
>> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
>> @@ -467,7 +467,7 @@ static int ni_atmio_attach(struct comedi_device *dev,
>> return -EIO;
>>
>> dev->board_ptr = ni_boards + board;
>> - boardtype = comedi_board(dev)
>> + boardtype = comedi_board(dev);
>>
>> printk(" %s", boardtype->name);
>> dev->board_name = boardtype->name;
>
> Ironically, that was introduced by a patch titled "staging: comedi:
> ni_atmio: fix build errors". :-)
My only excuse is that the coffee machine was broken...
Actually, I just realized that this driver as well as the others that depend
on ISAPNP were not being compiled on my Debian 6.0 64bit system . I
hacked my config to build the ones that depend on ISA but missed the
ISAPNP ones.
Sorry about the trouble.
Hartley
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon
2013-03-15 8:14 [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon Kumar Amit Mehta
2013-03-15 9:41 ` Ian Abbott
@ 2013-03-15 16:04 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2013-03-15 16:04 UTC (permalink / raw)
To: Kumar Amit Mehta; +Cc: abbotti, devel, fmhess, kernel-janitors, linux-kernel
On Fri, Mar 15, 2013 at 01:14:29AM -0700, Kumar Amit Mehta wrote:
> fix a missing end-of-statement by adding a semicolon.
>
> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hartley sent a fix for this yesterday, sorry about not applying it
sooner.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-15 16:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-15 8:14 [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon Kumar Amit Mehta
2013-03-15 9:41 ` Ian Abbott
2013-03-15 16:03 ` H Hartley Sweeten
2013-03-15 16:04 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox