Re: [PATCH 1/1] mfd: palmas: Add power off control

[Stephen Warren <swarren@wwwdotorg.org>]

On 03/14/2013 11:51 PM, Bill Huang wrote:
> On Fri, 2013-03-15 at 13:19 +0800, Stephen Warren wrote:
>> On 03/14/2013 04:58 AM, Bill Huang wrote:
>>> Hook up "pm_power_off" to palmas power off routine if there is DT
>>> property "ti,system-power-controller" defined, so platform which is
>>> powered by this regulator can be powered off properly.
>>
>>> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
>>
>>> +	pdata->pm_off = of_property_read_bool(node,
>>> +			"ti,system-power-controller");
>>
>> You would need to add that property to the DT binding documentation for
>> this device.
>
> Does it work that some time later Laxmain helps to add it when he
> submits his pmic bindings for Palmas?

I'll note that Ian Lartey and Graeme Gregory actually seem to be the
people defining the PMIC bindings for Palmas. See:

http://comments.gmane.org/gmane.linux.documentation/9948

Or is Laxman planning to send some updates to that?

But irrespective of that no, I don't think that influences this at all;
if you introduce driver support for new DT content, then either that DT
content should already be documented in the binding, or this patch
should add it to the documentation.