From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754767Ab3COS1F (ORCPT ); Fri, 15 Mar 2013 14:27:05 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:42612 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424Ab3COS1D (ORCPT ); Fri, 15 Mar 2013 14:27:03 -0400 Message-ID: <514367F3.6040909@wwwdotorg.org> Date: Fri, 15 Mar 2013 12:26:59 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Laxman Dewangan CC: linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 3/5] ARM: tegra:add aliases and DMA requestor for serial nodes of Tegra114 References: <1363204194-19487-1-git-send-email-ldewangan@nvidia.com> <1363204194-19487-4-git-send-email-ldewangan@nvidia.com> <5140DB61.3090809@wwwdotorg.org> In-Reply-To: <5140DB61.3090809@wwwdotorg.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2013 02:02 PM, Stephen Warren wrote: > On 03/13/2013 01:49 PM, Laxman Dewangan wrote: >> Add APB DMA requestor and serial aliases for serial controller. >> There will be two serial driver i.e. 8250 based simple serial driver >> and APB DMA based serial driver for higher baudrate and performace. >> >> The simple serial driver get enabled with compatible "nvidia,tegra114-uart", >> "nvidia,tegra20-uart" and APB DMA based driver will get enabled with >> compatible "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". > >> + /* >> + * There are two serial driver i.e. 8250 based simple serial >> + * driver and APB DMA based serial driver for higher baudrate >> + * and performace. To enable the 8250 based driver, the compatible >> + * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable >> + * the APB DMA based serial driver, the comptible is >> + * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". >> + */ > > Again, that text says you want either of: > > compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart"; > compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart"; > > (note Tegra20-vs-Tegra30 in the second compatible value) > > Why isn't it instead: > > compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart"; > compatible = "nvidia,tegra114-hsuart", "nvidia,tegra20-hsuart"; > > (note both second compatible values say Tegra20) > > I assume this is a typo. > > I suppose I can fix this up when I apply it to avoid a resend, assuming > it's wrong. Since I haven't seen a reply to this, when I apply this, I'm going to change the comment I quoted above to match the values I wrote above under "why isn't it instead:".