From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 3/5] ARM: tegra:add aliases and DMA requestor for serial nodes of Tegra114
Date: Sat, 16 Mar 2013 00:13:50 +0530 [thread overview]
Message-ID: <51436BE6.8070207@nvidia.com> (raw)
In-Reply-To: <514367F3.6040909@wwwdotorg.org>
On Friday 15 March 2013 11:56 PM, Stephen Warren wrote:
> On 03/13/2013 02:02 PM, Stephen Warren wrote:
>> On 03/13/2013 01:49 PM, Laxman Dewangan wrote:
>>> Add APB DMA requestor and serial aliases for serial controller.
>>> There will be two serial driver i.e. 8250 based simple serial driver
>>> and APB DMA based serial driver for higher baudrate and performace.
>>>
>>> The simple serial driver get enabled with compatible "nvidia,tegra114-uart",
>>> "nvidia,tegra20-uart" and APB DMA based driver will get enabled with
>>> compatible "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart".
>>> + /*
>>> + * There are two serial driver i.e. 8250 based simple serial
>>> + * driver and APB DMA based serial driver for higher baudrate
>>> + * and performace. To enable the 8250 based driver, the compatible
>>> + * is "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable
>>> + * the APB DMA based serial driver, the comptible is
>>> + * "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart".
>>> + */
>> Again, that text says you want either of:
>>
>> compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart";
>> compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart";
>>
>> (note Tegra20-vs-Tegra30 in the second compatible value)
>>
>> Why isn't it instead:
>>
>> compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart";
>> compatible = "nvidia,tegra114-hsuart", "nvidia,tegra20-hsuart";
>>
>> (note both second compatible values say Tegra20)
>>
>> I assume this is a typo.
>>
>> I suppose I can fix this up when I apply it to avoid a resend, assuming
>> it's wrong.
> Since I haven't seen a reply to this, when I apply this, I'm going to
> change the comment I quoted above to match the values I wrote above
> under "why isn't it instead:".
Stephen,
Sorry, I missed your comment to reply.
I mean was that compatible should be
compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart";
compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart";
not
compatible = "nvidia,tegra114-uart", "nvidia,tegra20-uart";
compatible = "nvidia,tegra114-hsuart", "nvidia,tegra20-hsuart";
The reason is that, tegra30 has the clock divider in the CAR register
set and it is 15.1 which gives more precise baudrate. tegra20 does not
have the same.
Tegra114 also have the clock divider in the CAR register.
All SoCs UART support 16.0 clock divider inside the uart controller as
DLL/DLM.
Simple uart driver use the uart clock divider and it is fine here.
High speed uart driver uses the car register driver for better
flexibility and better resolution.
next prev parent reply other threads:[~2013-03-15 18:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 19:49 [PATCH V3 0/5] ARM: DT: tegra114: Add DT entry for different controller Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 1/5] ARM: tegra: add APB DMA nodes to Tegra114 DT Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 2/5] ARM: tegra: add i2c " Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 3/5] ARM: tegra:add aliases and DMA requestor for serial nodes of Tegra114 Laxman Dewangan
2013-03-13 20:02 ` Stephen Warren
2013-03-15 18:26 ` Stephen Warren
2013-03-15 18:42 ` Laxman Dewangan
2013-03-15 18:58 ` Stephen Warren
2013-03-15 19:03 ` Laxman Dewangan
2013-03-15 18:43 ` Laxman Dewangan [this message]
2013-03-13 19:49 ` [PATCH V3 4/5] ARM: tegra: add KBC nodes to Tegra114 DT Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 5/5] ARM: tegra: add spi " Laxman Dewangan
2013-03-15 18:42 ` Stephen Warren
2013-03-15 18:47 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51436BE6.8070207@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox