From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: wsa@the-dreams.de, khali@linux-fr.org, linux-i2c@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: tegra: check the clk_prepare_enable() return value
Date: Fri, 15 Mar 2013 13:32:49 -0600 [thread overview]
Message-ID: <51437761.6020901@wwwdotorg.org> (raw)
In-Reply-To: <1363361648-10326-1-git-send-email-ldewangan@nvidia.com>
On 03/15/2013 09:34 AM, Laxman Dewangan wrote:
> NVIDIA's Tegra SoC allows read/write of controller register only
> if controller clock is enabled. System hangs if read/write happens
> to registers without enabling clock.
>
> clk_prepare_enable() can be fail due to unknown reason and hence
> adding check for return value of this function. If this function
> success then only access register otherwise return to caller with
> error.
Wolfram,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
This is probably suitable for Cc: stable.
next prev parent reply other threads:[~2013-03-15 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 15:34 [PATCH] i2c: tegra: check the clk_prepare_enable() return value Laxman Dewangan
2013-03-15 19:32 ` Stephen Warren [this message]
2013-03-22 9:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51437761.6020901@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=khali@linux-fr.org \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox