From: "Josef Ahmad" <josef.ahmad@linux.intel.com>
To: "Wolfram Sang" <wsa@the-dreams.de>
Cc: "Josef Ahmad" <josef.ahmad@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Ben Dooks" <ben-linux@fluff.org>,
"Jean Delvare" <khali@linux-fr.org>, "Stefan Roese" <sr@denx.de>,
"Axel Lin" <axel.lin@gmail.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dirk Brandewie" <dirk.brandewie@gmail.com>
Subject: Re: [PATCH] i2c-designware: fix RX FIFO overrun
Date: Tue, 23 Apr 2013 10:44:42 -0700 (PDT) [thread overview]
Message-ID: <51465.163.33.213.85.1366739082.squirrel@linux.intel.com> (raw)
In-Reply-To: <20130423163543.GB3228@the-dreams.de>
> On Mon, Apr 22, 2013 at 03:08:59PM +0100, Josef Ahmad wrote:
>> From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001
>> From: Josef Ahmad <josef.ahmad@linux.intel.com>
>> Date: Fri, 19 Apr 2013 17:28:10 +0100
>> Subject: [PATCH] i2c-designware: fix RX FIFO overrun
>>
>> i2c_dw_xfer_msg() pushes a number of bytes to transmit/receive
>> to/from the bus into the TX FIFO.
>> For master-rx transactions, the maximum amount of data that can be
>> received is calculated depending solely on TX and RX FIFO load.
>>
>> This is racy - TX FIFO may contain master-rx data yet to be
>> processed, which will eventually land into the RX FIFO. This
>> data is not taken into account and the function may request more
>> data than the controller is actually capable of storing.
>>
>> This patch ensures the driver takes into account the outstanding
>> master-rx data in TX FIFO to prevent RX FIFO overrun.
>>
>> Signed-off-by: Josef Ahmad <josef.ahmad@linux.intel.com>
>> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> This driver had a major cleanup meanwhile. Could you rebase your patch
> on top of my for-next branch? I guess this version should make it into
> stable?
>
Hi Wolfram
This patch applies just fine on top of your i2c-embedded/for-next branch.
next prev parent reply other threads:[~2013-04-23 17:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 18:05 [PATCH] i2c-designware: fix RX FIFO overrun Josef Ahmad
2013-04-19 20:43 ` Bryan O'Donoghue
2013-04-19 21:20 ` Josef Ahmad
2013-04-22 7:19 ` Mika Westerberg
2013-04-22 11:30 ` Josef Ahmad
2013-04-22 12:28 ` Mika Westerberg
2013-04-22 14:08 ` Josef Ahmad
2013-04-23 16:35 ` Wolfram Sang
2013-04-23 17:44 ` Josef Ahmad [this message]
2013-04-23 18:27 ` Wolfram Sang
2013-04-24 10:11 ` Josef Ahmad
2013-04-25 17:43 ` Wolfram Sang
2013-05-08 13:31 ` Josef Ahmad
2013-05-08 13:34 ` Josef Ahmad
2013-05-17 8:23 ` Wolfram Sang
2013-05-17 8:32 ` Wolfram Sang
2013-05-17 10:59 ` Josef Ahmad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51465.163.33.213.85.1366739082.squirrel@linux.intel.com \
--to=josef.ahmad@linux.intel.com \
--cc=axel.lin@gmail.com \
--cc=ben-linux@fluff.org \
--cc=dirk.brandewie@gmail.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sr@denx.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox