From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Gleb Natapov <gleb@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 4/5] KVM: MMU: store generation-number into mmio spte
Date: Mon, 18 Mar 2013 12:19:12 +0100 [thread overview]
Message-ID: <5146F830.1070602@redhat.com> (raw)
In-Reply-To: <51433E43.60900@linux.vnet.ibm.com>
Il 15/03/2013 16:29, Xiao Guangrong ha scritto:
> +/*
> + * spte bits of bit 3 ~ bit 11 are used as low 9 bits of
> + * generation, the bits of bits 52 ~ bit 61 are used as
> + * high 12 bits of generation.
> + */
High 10 bits.
How often does the generation number change? Especially with Takuya's
patches, using just 10 bits for the generation might be enough and
simplifies the code.
Paolo
next prev parent reply other threads:[~2013-03-18 11:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 15:26 [PATCH 0/5] KVM: MMU: fast invalid all mmio sptes Xiao Guangrong
2013-03-15 15:26 ` [PATCH 1/5] Revert "KVM: x86: Optimize mmio spte zapping when, creating/moving memslot" Xiao Guangrong
2013-03-16 2:07 ` Takuya Yoshikawa
2013-03-18 7:36 ` Xiao Guangrong
2013-03-15 15:27 ` [PATCH 2/5] Revert "KVM: MMU: Mark sp mmio cached when creating mmio spte" Xiao Guangrong
2013-03-15 15:28 ` [PATCH 3/5] KVM: MMU: retain more available bits available on mmio spte Xiao Guangrong
2013-03-15 15:29 ` [PATCH 4/5] KVM: MMU: store generation-number into " Xiao Guangrong
2013-03-18 11:19 ` Paolo Bonzini [this message]
2013-03-18 12:42 ` Xiao Guangrong
2013-03-18 12:48 ` Gleb Natapov
2013-03-20 18:43 ` Marcelo Tosatti
2013-03-15 15:29 ` [PATCH 5/5] KVM: MMU: fast invalid all mmio sptes Xiao Guangrong
2013-03-16 2:13 ` Takuya Yoshikawa
2013-03-18 7:38 ` Xiao Guangrong
2013-03-17 15:02 ` Gleb Natapov
2013-03-18 8:08 ` Xiao Guangrong
2013-03-18 9:13 ` Gleb Natapov
2013-03-18 12:29 ` Xiao Guangrong
2013-03-18 12:46 ` Gleb Natapov
2013-03-18 13:09 ` Xiao Guangrong
2013-03-18 13:19 ` Gleb Natapov
2013-03-18 13:25 ` Xiao Guangrong
2013-03-18 13:27 ` Gleb Natapov
2013-03-18 13:32 ` Xiao Guangrong
2013-03-18 22:16 ` Eric Northup
2013-03-19 3:15 ` Xiao Guangrong
2013-03-19 7:36 ` Gleb Natapov
2013-03-19 7:52 ` Xiao Guangrong
2013-03-16 2:06 ` [PATCH 0/5] " Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5146F830.1070602@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox