From: Chanwoo Choi <cw00.choi@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com
Subject: Re: [PATCH 1/1] extcon: max77693: Staticize default_init_data
Date: Tue, 19 Mar 2013 18:35:41 +0900 [thread overview]
Message-ID: <5148316D.9040801@samsung.com> (raw)
In-Reply-To: <1363666036-14006-1-git-send-email-sachin.kamat@linaro.org>
On 03/19/2013 01:07 PM, Sachin Kamat wrote:
> Commit 0ec83bd246 ("extcon: max77693: Initialize register of MUIC
> device to bring up it without platform data") added this structure
> but forgot to make it static. Without this patch we get the following
> warning:
> drivers/extcon/extcon-max77693.c:41:26: warning:
> symbol 'default_init_data' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/extcon/extcon-max77693.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 8f3c947..7b2e93d 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -38,7 +38,7 @@
> * extcon-max77693 driver use 'default_init_data' to bring up base operation
> * of MAX77693 MUIC device.
> */
> -struct max77693_reg_data default_init_data[] = {
> +static struct max77693_reg_data default_init_data[] = {
> {
> /* STATUS2 - [3]ChgDetRun */
> .addr = MAX77693_MUIC_REG_STATUS2,
Applied it. Thanks.
Chanwoo Choi
prev parent reply other threads:[~2013-03-19 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 4:07 [PATCH 1/1] extcon: max77693: Staticize default_init_data Sachin Kamat
2013-03-19 9:35 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148316D.9040801@samsung.com \
--to=cw00.choi@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox