From: Chanwoo Choi <cw00.choi@samsung.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'MyungJoo Ham'" <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] extcon: max8997: use dev_err() instead of pr_err()
Date: Tue, 19 Mar 2013 18:36:04 +0900 [thread overview]
Message-ID: <51483184.6070009@samsung.com> (raw)
In-Reply-To: <000101ce2462$e31b5fa0$a9521ee0$%han@samsung.com>
On 03/19/2013 02:30 PM, Jingoo Han wrote:
> dev_err() is more preferred than pr_err().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> No Changes since v1:
>
> drivers/extcon/extcon-max8997.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 69641bc..20772ad 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -646,7 +646,7 @@ static void max8997_muic_detect_cable_wq(struct work_struct *work)
>
> ret = max8997_muic_detect_dev(info);
> if (ret < 0)
> - pr_err("failed to detect cable type\n");
> + dev_err(info->dev, "failed to detect cable type\n");
> }
>
> static int max8997_muic_probe(struct platform_device *pdev)
Applied it. Thanks.
Chanwoo Choi
prev parent reply other threads:[~2013-03-19 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 5:30 [PATCH v2 1/2] extcon: max8997: use dev_err() instead of pr_err() Jingoo Han
2013-03-19 5:31 ` [PATCH v2 2/2] extcon: max8997: add missing const Jingoo Han
2013-03-19 9:45 ` Chanwoo Choi
2013-03-19 10:29 ` Jingoo Han
2013-03-19 9:36 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51483184.6070009@samsung.com \
--to=cw00.choi@samsung.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox