Re: e1000e + suspend, 3.9-rc2

[Jiri Slaby <jslaby@suse.cz>]

On 03/19/2013 11:27 AM, Konstantin Khlebnikov wrote:
> Jiri Slaby wrote:
>> On 03/12/2013 06:17 PM, Borislav Petkov wrote:
>>> On Mon, Mar 11, 2013 at 09:25:37PM +0100, Borislav Petkov wrote:
>>>> Yeah, it is already upstream. And yeah, it did trigger with it.
>>>>
>>>> $ git describe
>>>> v3.9-rc2-112-g7c6baa304b84
>>>>
>>>> But it somehow doesn't trigger with that same kernel anymore so I'll
>>>> consider it a glitch and watch it over the next days.
>>>
>>> Ok, I can still see the hardware error message when suspending:
>>
>> And with 3.8 plus these:
>>      PCI/PM: Clear state_saved during suspend
>>      e1000e: fix pci-device enable-counter balance
>>      e1000e: fix runtime power management transitions
>>      e1000e: fix accessing to suspended device
>>
>> I sometimes see this:
>> pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2
>> dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
>> PM: Device 0000:00:19.0 failed to suspend async: error -2
>>
>> Any ideas? Am I missing some patch still?
> 
> Try this:
> "PCI: Don't try to disable Bus Master on disconnected PCI devices"
> https://patchwork.kernel.org/patch/2271641/
> 
> But I'm not sure, probably it is unrelated because this code works only (?)
> during shutdown/kexec sequences.

I don't think it will help either. -2 here is -E1000_ERR_PHY from
e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready
or unlike MDIC_ERROR.

I think this happened after I put the link down and tried to suspend.

-- 
js
suse labs