From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: sameo@linux.intel.com, swarren@nvidia.com,
broonie@opensource.wolfsonmicro.com, gg@slimlogic.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client
Date: Tue, 19 Mar 2013 09:44:24 -0600 [thread overview]
Message-ID: <514887D8.2020606@wwwdotorg.org> (raw)
In-Reply-To: <1363683500-24891-1-git-send-email-ldewangan@nvidia.com>
On 03/19/2013 02:58 AM, Laxman Dewangan wrote:
> Palmas device have three different i2c addresses. The device creates
> the two new dummy i2c clients for accessing the register by using
> primary client adapter. This new dummy i2c client have their of_node
> as NULL.
>
> The dummy i2c client is used for registering interrupt and on this,
> it creates irq domain handle. This created irq domain handle has
> their of_node as NULL.
It seems like part of the solution here is to modify the i2c_client
object itself so that it can directly support devices that have multiple
I2C addresses; instead of 1 i2c_client representing 1 address, 1
i2c_client could represent a list of addresses, that list being
populated directly from the list contained in the top-level node's reg
property. That way, you wouldn't need any dummy i2c_clients, which would
avoid this issue.
If the I2C device itself has multiple I2C addresses, they really should
all be explicitly listed in the device tree reg property.
next prev parent reply other threads:[~2013-03-19 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 8:58 [PATCH] mfd: palmas: initialise client->of_node for dummy created client Laxman Dewangan
2013-03-19 9:23 ` Graeme Gregory
2013-03-19 15:44 ` Stephen Warren [this message]
[not found] ` <20130319165228.GC22168@opensource.wolfsonmicro.com>
2013-03-19 17:10 ` Stephen Warren
[not found] ` <20130319172648.GD22168@opensource.wolfsonmicro.com>
2013-03-20 14:39 ` Laxman Dewangan
2013-04-08 12:55 ` Laxman Dewangan
2013-04-08 16:14 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514887D8.2020606@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox