From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "Yu, Fenghua" <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"penguin-kernel@i-love.sakura.ne.jp"
<penguin-kernel@i-love.sakura.ne.jp>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH] x86/microcode_intel_early.c: Get 32-bit physical address by __pa_nodebug()
Date: Tue, 19 Mar 2013 17:03:45 -0700 [thread overview]
Message-ID: <5148FCE1.9010009@zytor.com> (raw)
In-Reply-To: <CAE9FiQVHqt+Tx4vLuHQUQoZ-PcaGO4-oq7SjA5oq_M6mJh9DDQ@mail.gmail.com>
On 03/19/2013 04:48 PM, Yinghai Lu wrote:
>
> So do you mean we have to change all __pa_symbol before
> setup.c::setup_arch/find_low_pfn_range ?
> because only at that time max_low_pfn get setup.
>
No, I suspect the problem is that the debugging code fails to notice
that max_low_pfn isn't set up yet because it is in linear mode, and so
it reads the wrong address when it checks max_low_pfn.
-hpa
next prev parent reply other threads:[~2013-03-20 0:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 15:04 [PATCH] x86/microcode_intel_early.c: Get 32-bit physical address by __pa_nodebug() Fenghua Yu
2013-03-19 23:15 ` Yinghai Lu
2013-03-19 23:21 ` H. Peter Anvin
2013-03-19 23:36 ` Yu, Fenghua
2013-03-19 23:48 ` Yinghai Lu
2013-03-20 0:03 ` H. Peter Anvin [this message]
2013-03-20 2:06 ` Tetsuo Handa
2013-03-20 3:11 ` [tip:x86/urgent] x86-32, microcode_intel_early: Fix crash with CONFIG_DEBUG_VIRTUAL tip-bot for Fenghua Yu
2013-03-21 10:40 ` [PATCH] x86/microcode_intel_early.c: Get 32-bit physical address by __pa_nodebug() Ingo Molnar
2013-03-21 14:30 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148FCE1.9010009@zytor.com \
--to=hpa@zytor.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox