* [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus to __initdata spinning_secondaries
@ 2013-03-20 6:30 Chen Gang
2013-03-25 4:28 ` Chen Gang
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2013-03-20 6:30 UTC (permalink / raw)
To: Benjamin Herrenschmidt, paulus@samba.org, michael, dhowells,
geoff
Cc: linuxppc-dev,
linux-kernel@vger.kernel.org >> "linux-kernel@vger.kernel.org"
the smp_release_cpus is a normal funciton and called in normal environments,
but it calls the __initdata spinning_secondaries.
need modify spinning_secondaries to match smp_release_cpus.
the related warning:
(the linker report boot_paca.33377, but it should be spinning_secondaries)
-----------------------------------------------------------------------------
WARNING: arch/powerpc/kernel/built-in.o(.text+0x23176): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
The function .smp_release_cpus() references
the variable __initdata boot_paca.33377.
This is often because .smp_release_cpus lacks a __initdata
annotation or the annotation of boot_paca.33377 is wrong.
WARNING: arch/powerpc/kernel/built-in.o(.text+0x231fe): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
The function .smp_release_cpus() references
the variable __initdata boot_paca.33377.
This is often because .smp_release_cpus lacks a __initdata
annotation or the annotation of boot_paca.33377 is wrong.
-----------------------------------------------------------------------------
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/powerpc/kernel/setup_64.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 75fbaceb..e8a2f2e 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -76,7 +76,7 @@
#endif
int boot_cpuid = 0;
-int __initdata spinning_secondaries;
+int spinning_secondaries;
u64 ppc64_pft_size;
/* Pick defaults since we might want to patch instructions
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus to __initdata spinning_secondaries
2013-03-20 6:30 [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus to __initdata spinning_secondaries Chen Gang
@ 2013-03-25 4:28 ` Chen Gang
0 siblings, 0 replies; 2+ messages in thread
From: Chen Gang @ 2013-03-25 4:28 UTC (permalink / raw)
To: Benjamin Herrenschmidt, paulus@samba.org, michael, dhowells,
geoff, sfr@canb.auug.org.au, Michael Neuling
Cc: linuxppc-dev,
linux-kernel@vger.kernel.org >> "linux-kernel@vger.kernel.org"
Hello Maintainers:
could you help check this patch whether is ok ?
thanks.
On 2013年03月20日 14:30, Chen Gang wrote:
>
> the smp_release_cpus is a normal funciton and called in normal environments,
> but it calls the __initdata spinning_secondaries.
> need modify spinning_secondaries to match smp_release_cpus.
>
> the related warning:
> (the linker report boot_paca.33377, but it should be spinning_secondaries)
>
> -----------------------------------------------------------------------------
>
> WARNING: arch/powerpc/kernel/built-in.o(.text+0x23176): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
> The function .smp_release_cpus() references
> the variable __initdata boot_paca.33377.
> This is often because .smp_release_cpus lacks a __initdata
> annotation or the annotation of boot_paca.33377 is wrong.
>
> WARNING: arch/powerpc/kernel/built-in.o(.text+0x231fe): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
> The function .smp_release_cpus() references
> the variable __initdata boot_paca.33377.
> This is often because .smp_release_cpus lacks a __initdata
> annotation or the annotation of boot_paca.33377 is wrong.
>
> -----------------------------------------------------------------------------
>
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/powerpc/kernel/setup_64.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 75fbaceb..e8a2f2e 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -76,7 +76,7 @@
> #endif
>
> int boot_cpuid = 0;
> -int __initdata spinning_secondaries;
> +int spinning_secondaries;
> u64 ppc64_pft_size;
>
> /* Pick defaults since we might want to patch instructions
>
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-25 4:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-20 6:30 [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus to __initdata spinning_secondaries Chen Gang
2013-03-25 4:28 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).