From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757257Ab3CUGYB (ORCPT ); Thu, 21 Mar 2013 02:24:01 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:39368 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757212Ab3CUGX5 (ORCPT ); Thu, 21 Mar 2013 02:23:57 -0400 Message-ID: <514AA74D.9070506@ti.com> Date: Thu, 21 Mar 2013 11:53:09 +0530 From: kishon User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Stephen Warren CC: , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data References: <1363770725-13717-1-git-send-email-kishon@ti.com> <1363770725-13717-6-git-send-email-kishon@ti.com> <514A233F.8010105@wwwdotorg.org> In-Reply-To: <514A233F.8010105@wwwdotorg.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 21 March 2013 02:29 AM, Stephen Warren wrote: > On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote: >> Updated the usb_otg_hs dt data to include the *phy* and *phy-names* >> binding in order for the driver to use the new generic PHY framework. >> Also updated the Documentation to include the binding information. > >> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt >> index abce256..3d6f9f6 100644 >> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt >> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt >> @@ -19,6 +19,9 @@ OMAP MUSB GLUE >> - power : Should be "50". This signifies the controller can supply upto >> 100mA when operating in host mode. >> - usb-phy : the phandle for the PHY device >> + - phy : the phandle for the PHY device (used by generic PHY framework) >> + - phy-names : the names of the PHY corresponding to the PHYs present in the >> + *phy* phandle. > > If the intent is for those properties to be generic and used by any DT > binding that refers to a PHY node, I think you'd want to define those > properties in e.g. Documentation/devicetree/bindings/phy/phy.txt, just > like common clock/GPIO/... properties are defined in standalone common > files. Ok. Will add it. > > I think you want to require that DT nodes that represent PHYs have a > #phy-cells property, and that the format of the phy property be > <&phy_phandle phy_specifier*>, where #phy-cells in the referenced node > defines how many cells are part of phy_specifier*, just like (almost) > any other DT property that references another node by phandle. That way, > if a single DT node represents a HW block that implements e.g. 3 PHYs, > it can use #phy-cells = <1>, and the referencing phy property can > include a cell that indicates which of those 3 PHYs is being referenced. Currently, if a single phandle have reference to multiple PHYs, we can get PHY by passing index or by name as give in phy-names. I'm not sure if we have <&phy_phandle phy_specifier*>, what could that phy_specifier be? Maybe phy_type? Thanks Kishon