From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752244Ab3CUSWL (ORCPT ); Thu, 21 Mar 2013 14:22:11 -0400 Received: from mga14.intel.com ([143.182.124.37]:65390 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073Ab3CUSWK (ORCPT ); Thu, 21 Mar 2013 14:22:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,887,1355126400"; d="scan'208";a="217458428" Message-ID: <514B4FCF.7080509@intel.com> Date: Thu, 21 Mar 2013 11:22:07 -0700 From: Dave Jiang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Vinod Koul CC: "djbw@fb.com" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "Mason, Jon" Subject: Re: [PATCH v2] ioat: remove chanerr mask setting for IOAT v3.x References: <20121127221608.11315.49374.stgit@djiang5-linux.ch.intel.com> <20130321050301.GB10326@intel.com> In-Reply-To: <20130321050301.GB10326@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2013 10:03 PM, Vinod Koul wrote: > On Wed, Nov 28, 2012 at 03:46:08AM +0530, Jiang, Dave wrote: >> The existing code set a value in the PCI_CHANERRMSK_INT register >> for a workaround to address a pre-silicon bug on the Intel 5520 IO hub that >> has been fixed when the hardware was released. There is no need for this >> code. >> >> Signed-off-by: Dave Jiang >> --- >> >> drivers/dma/ioat/dma_v3.c | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c >> index f7f1dc6..fda3b8a1 100644 >> --- a/drivers/dma/ioat/dma_v3.c >> +++ b/drivers/dma/ioat/dma_v3.c >> @@ -1126,12 +1126,7 @@ static int ioat3_reset_hw(struct ioat_chan_common *chan) >> chanerr = readl(chan->reg_base + IOAT_CHANERR_OFFSET); >> writel(chanerr, chan->reg_base + IOAT_CHANERR_OFFSET); >> >> - /* -= IOAT ver.3 workarounds =- */ >> - /* Write CHANERRMSK_INT with 3E07h to mask out the errors >> - * that can cause stability issues for IOAT ver.3, and clear any >> - * pending errors >> - */ > What is this code based against? i dont have above lines in -rc1 or my next? Looking at the Linus tree it looks like it's already upstream somehow? Commit 6decffd. >> - pci_write_config_dword(pdev, IOAT_PCI_CHANERRMASK_INT_OFFSET, 0x3e07); >> + /* clear any pending errors */ >> err = pci_read_config_dword(pdev, IOAT_PCI_CHANERR_INT_OFFSET, &chanerr); >> if (err) { >> dev_err(&pdev->dev, "channel error register unreachable\n"); >>