From: Chen Gang <gang.chen@asianux.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"paulus@samba.org" <paulus@samba.org>,
michael@ellerman.id.au, dhowells@redhat.com, geoff@infradead.org,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@lists.ozlabs.org,
"linux-kernel@vger.kernel.org >>
\"linux-kernel@vger.kernel.org\"" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus to __initdata spinning_secondaries
Date: Mon, 25 Mar 2013 12:28:43 +0800 [thread overview]
Message-ID: <514FD27B.6050706@asianux.com> (raw)
In-Reply-To: <51495774.9080809@asianux.com>
Hello Maintainers:
could you help check this patch whether is ok ?
thanks.
On 2013年03月20日 14:30, Chen Gang wrote:
>
> the smp_release_cpus is a normal funciton and called in normal environments,
> but it calls the __initdata spinning_secondaries.
> need modify spinning_secondaries to match smp_release_cpus.
>
> the related warning:
> (the linker report boot_paca.33377, but it should be spinning_secondaries)
>
> -----------------------------------------------------------------------------
>
> WARNING: arch/powerpc/kernel/built-in.o(.text+0x23176): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
> The function .smp_release_cpus() references
> the variable __initdata boot_paca.33377.
> This is often because .smp_release_cpus lacks a __initdata
> annotation or the annotation of boot_paca.33377 is wrong.
>
> WARNING: arch/powerpc/kernel/built-in.o(.text+0x231fe): Section mismatch in reference from the function .smp_release_cpus() to the variable .init.data:boot_paca.33377
> The function .smp_release_cpus() references
> the variable __initdata boot_paca.33377.
> This is often because .smp_release_cpus lacks a __initdata
> annotation or the annotation of boot_paca.33377 is wrong.
>
> -----------------------------------------------------------------------------
>
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/powerpc/kernel/setup_64.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 75fbaceb..e8a2f2e 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -76,7 +76,7 @@
> #endif
>
> int boot_cpuid = 0;
> -int __initdata spinning_secondaries;
> +int spinning_secondaries;
> u64 ppc64_pft_size;
>
> /* Pick defaults since we might want to patch instructions
>
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-03-25 4:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 6:30 [PATCH] PowerPC:kernel: section mismatch from smp_release_cpus to __initdata spinning_secondaries Chen Gang
2013-03-25 4:28 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514FD27B.6050706@asianux.com \
--to=gang.chen@asianux.com \
--cc=benh@kernel.crashing.org \
--cc=dhowells@redhat.com \
--cc=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).