From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121AbbIKUgk (ORCPT ); Fri, 11 Sep 2015 16:36:40 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:55451 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922AbbIKUgi (ORCPT ); Fri, 11 Sep 2015 16:36:38 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Peter Griffin , linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, vinod.koul@intel.com, devicetree@vger.kernel.org, robh+dt@kernel.org, dmaengine@vger.kernel.org, lee.jones@linaro.org, Ludovic Barre Subject: Re: [PATCH v2 1/9] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Date: Fri, 11 Sep 2015 22:36 +0200 Message-ID: <51503956.PMFrWKUjxX@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1441980871-24475-2-git-send-email-peter.griffin@linaro.org> References: <1441980871-24475-1-git-send-email-peter.griffin@linaro.org> <1441980871-24475-2-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ZXKDcjHU789+1/Fc9815kqN5mlaXsPCbLw0YZKYyID7XecMZlnU gIgG3WnZzjAIXb4F7dyRWFVoeb0QCYZLzGmSyhV/GtLQ9j9otqEWNDrkAp6RyCbeuR0vxX5 qHXy80O+AaAVtXEZImJt4bm6h89+C1Z0DtUSjomwytIqoVVfvv5htyZ4Vhbr36DKNzpVDqj zP0yQse/w6iuTOrm+NnuQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:9jjRRk/6dAI=:eagmeF2dVSN3RsCZKp6dnG bIY4C4ggxOwRKCnxnZ9SMsbR9ysYJ55sYweUDyR/tDzOFvpdikdDIb/biqwGEKzz4+UjhE4QU n2u227s0TnrkVygkPwlYO8LU5xzxakGFbJOVg5xDtC3JnJ9ekWPVlTpcYofPTdAGQHdJ6RXbI /F9GwpKLkXKZzdkKQtHSSK7wn9hTmmyiM7vE9CyMMlGhKVlqJhtU1B+F1dGi50WUIjhRDhjA6 CHzfF9kKfdNhaUUCWH3BERXqY4dZXDmzBIL8NPvIE4XS+mhajcmdEPszrkKboPzm3+6mv/+jT adm+Yk5fRdMrG3tjzSp92tRIhJWxGfI6uBftQ2P4vZh708h1eYYoFBFZtK2UBwUZZDtAXjYnp J2u1zBUjTIKrzeJH6mUvv9sdPIobxtRnT+UVW/0feiLSMk2vKsNvj/yoVBt7p3WXHh7QNjqIZ 70hhNbbmTDu7Hv8f1/CSUDFOqNn4hTRJRfFVto6gJGaDGLRGYjiw+6tHEmO3oXxW4fByVrfB4 8xoiv1HrrqOi2aYL7yPVnUFW44cluj28fAFX7qjzu+pFlVHHucuwaDFzR9Ukd9SBZKhE12vPM 1saEQ53m4QqyWN5702GCcY/9IqzIrIfYBUIw9pVsyXzl6HEcZW7dMtalXAMYll3RprVgqO656 BZ0mGGDqJap8wgm54Z1qUGAfi9jMc8C42Brs3/DhK9FytF5G37cDaEeh2fcoccI0mTWOtk1ry +aQYfPmEnnafOkNB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 11 September 2015 15:14:23 Peter Griffin wrote: > +- st,fdma-id : Must contain fdma controller number What for? > +Example: > + > + fdma1: fdma-app@8e40000 { The name should be "dma-controller", not "fdma-app". > +Example: > + > + snd_uni_player2: snd-uni-player@2 { > + compatible = "st,snd_uni_player"; Maybe change the compatible string to "st,snd-uni-player"? The string you use here would not be acceptable for a binding. Arnd