From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, shuge@allwinnertech.com,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
kevin@allwinnertech.com, sunny@allwinnertech.com
Subject: Re: [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string
Date: Mon, 25 Mar 2013 17:27:51 +0100 [thread overview]
Message-ID: <51507B07.4050204@free-electrons.com> (raw)
In-Reply-To: <51505825.2060805@gmail.com>
Hi Rob,
Le 25/03/2013 14:59, Rob Herring a écrit :
> On 03/25/2013 08:30 AM, Maxime Ripard wrote:
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> ---
>> arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
>> arch/arm/boot/dts/sun5i-a13.dtsi | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
>> index be71782..805d704 100644
>> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
>> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
>> @@ -121,7 +121,7 @@
>> ranges;
>>
>> intc: interrupt-controller@01c20400 {
>> - compatible = "allwinner,sunxi-ic";
>> + compatible = "allwinner,sun4i-ic";
>
> Generally speaking, this is a bad thing to do. This breaks compatibility
> between dtb and kernel versions. If that breakage is not yet a concern
> for sunxi, then it is okay.
Yes, I know, but I thought it was okay since sunxi has never been in an
usable state, and it seemed odd to me to begin to maintain an history
for a platform that has never actually been booted by a user.
On the other end, if someone speaks up, I'd be happy to keep the old
compatible around as well.
> Also, I don't see any documentation updates for any of these changes.
Ah, yes, my bad.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-03-25 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1364218233-29636-1-git-send-email-maxime.ripard@free-electrons.com>
2013-03-25 13:30 ` [PATCH 01/10] ARM: sunxi: dt: Reorganize the dtsi Maxime Ripard
2013-03-25 13:30 ` [PATCH 02/10] clocksource: sunxi: Cleanup the timer code Maxime Ripard
2013-03-25 13:30 ` [PATCH 03/10] clocksource: sunxi: make use of CLKSRC_OF Maxime Ripard
2013-03-25 13:50 ` Rob Herring
2013-03-25 16:23 ` Maxime Ripard
2013-03-25 13:30 ` [PATCH 04/10] clocksource: sunxi: Rename sunxi to sun4i Maxime Ripard
2013-03-25 13:30 ` [PATCH 05/10] ARM: sunxi: dt: Update timer compatible string Maxime Ripard
2013-03-25 13:30 ` [PATCH 06/10] irqchip: sunxi: Make use of the IRQCHIP_DECLARE macro Maxime Ripard
2013-03-25 13:30 ` [PATCH 07/10] irqchip: sunxi: Rename sunxi to sun4i Maxime Ripard
2013-03-25 14:00 ` Rob Herring
2013-03-25 13:30 ` [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller compatible string Maxime Ripard
2013-03-25 13:59 ` Rob Herring
2013-03-25 16:27 ` Maxime Ripard [this message]
2013-03-25 13:30 ` [PATCH 09/10] ARM: sunxi: Rework the restart code Maxime Ripard
2013-03-25 13:30 ` [PATCH 10/10] ARM: sunxi: dt: Update watchdog compatible string Maxime Ripard
[not found] <1364289198-11589-1-git-send-email-maxime.ripard@free-electrons.com>
2013-03-26 9:13 ` [PATCH 08/10] ARM: sunxi: dt: Update interrupt controller " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51507B07.4050204@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=kevin@allwinnertech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robherring2@gmail.com \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox