Re: [RFC PATCH v2, part4 09/39] mm: use totalram_pages instead of num_physpages at runtime

Sergei Shtylyov
2013-03-24T12:28:01Z

Hello.

On 24-03-2013 11:24, Jiang Liu wrote:

> The global variable num_physpages is scheduled to be removed, so use
> totalram_pages instead of num_physpages at runtime.

> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
> Cc: Miklos Szeredi <miklos@szeredi.hu>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> Cc: James Morris <jmorris@namei.org>
> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: fuse-devel@lists.sourceforge.net
> Cc: linux-kernel@vger.kernel.org
> Cc: netdev@vger.kernel.org
[...]

> diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c
> index 4750d2b..94a99a1 100644
> --- a/net/ipv4/inet_fragment.c
> +++ b/net/ipv4/inet_fragment.c
> @@ -60,7 +60,7 @@ void inet_frags_init(struct inet_frags *f)
>
> rwlock_init(&f->lock);
>
> - f->rnd = (u32) ((num_physpages ^ (num_physpages>>7)) ^
> + f->rnd = (u32) ((totalram_pages ^ (totalram_pages>>7)) ^

Wouldn't hurt to add spaces around >> for consistency's sake.

> (jiffies ^ (jiffies >> 6)));
>
> setup_timer(&f->secret_timer, inet_frag_secret_rebuild,

WBR, Sergei