From: Chen Gang <gang.chen@asianux.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
"nico@linaro.org" <nico@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void'
Date: Tue, 26 Mar 2013 09:22:57 +0800 [thread overview]
Message-ID: <5150F871.5050306@asianux.com> (raw)
In-Reply-To: <20130325233213.GA29245@kroah.com>
On 2013年03月26日 07:32, Greg KH wrote:
> On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote:
>>
>> better to let 'inline' in front of 'void'
>
> Why? What does this fix?
>
>
>
when I am compiling with "EXTRA_FLAGS=-W", I get a warning:
make V=1 EXTRA_CFLAGS=-W ARCH=arm randconfig
make V=1 EXTRA_CFLAGS=-W ARCH=arm menuconfig
choose arm-linux-gnu- for cross chain prefix.
choose S5pv210 for processor type
make V=1 EXTRA_CFLAGS=-W ARCH=arm
the warning is:
include/linux/platform_data/usb-ohci-s3c2410.h:34:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
it is only for beautify code, not fix a bug.
:-)
--
Chen Gang
Asianux Corporation
next prev parent reply other threads:[~2013-03-26 1:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 2:36 [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void' Chen Gang
2013-03-25 2:48 ` [Suggestion] scripts/checkpatch.pl: an issue about checking failed for a patch Chen Gang
2013-03-25 23:32 ` [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void' Greg KH
2013-03-26 1:22 ` Chen Gang [this message]
2013-03-26 1:48 ` Greg KH
2013-03-26 2:28 ` Chen Gang
2013-03-26 2:47 ` Nicolas Pitre
2013-03-26 3:00 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5150F871.5050306@asianux.com \
--to=gang.chen@asianux.com \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=nico@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox