From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759311Ab3CZC3O (ORCPT ); Mon, 25 Mar 2013 22:29:14 -0400 Received: from intranet.asianux.com ([58.214.24.6]:7343 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756064Ab3CZC3O (ORCPT ); Mon, 25 Mar 2013 22:29:14 -0400 X-Spam-Score: -100.8 Message-ID: <515107DB.4060508@asianux.com> Date: Tue, 26 Mar 2013 10:28:43 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Greg KH CC: Mark Brown , Mauro Carvalho Chehab , "nico@linaro.org" , Arnd Bergmann , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] include/linux/platform_data: beautify code, 'inline' is better in front of 'void' References: <514FB826.9020302@asianux.com> <20130325233213.GA29245@kroah.com> <5150F871.5050306@asianux.com> <20130326014830.GB6496@kroah.com> In-Reply-To: <20130326014830.GB6496@kroah.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2013年03月26日 09:48, Greg KH wrote: > On Tue, Mar 26, 2013 at 09:22:57AM +0800, Chen Gang wrote: >> On 2013年03月26日 07:32, Greg KH wrote: >>> On Mon, Mar 25, 2013 at 10:36:22AM +0800, Chen Gang wrote: >>>> >>>> better to let 'inline' in front of 'void' >>> >>> Why? What does this fix? >>> >>> >>> >> >> when I am compiling with "EXTRA_FLAGS=-W", I get a warning: > > That's not anything I really care about, sorry. No one sane builds the > kernel like that :) a hacker may find something "valuable" with the aid of compiler ;-) maybe, it is a patch which is too minor to apply. I can understand :-) thanks. > > greg k-h > > -- Chen Gang Asianux Corporation