From: Chen Gang <gang.chen@asianux.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: tglx@linutronix.de, Greg KH <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Suggestion] kernel: 'now' may be used uninitialized in posix_cpu_timer_schedule function
Date: Tue, 26 Mar 2013 20:32:09 +0800 [thread overview]
Message-ID: <51519549.5070204@asianux.com> (raw)
In-Reply-To: <CAFTL4hw2vc5C9gdf1bm413MftfaYB5PWxTuuU9C5iAuzD_YKEw@mail.gmail.com>
On 2013年03月26日 20:27, Frederic Weisbecker wrote:
> 2013/3/26 Chen Gang <gang.chen@asianux.com>:
>> > Hello Maintainers:
>> >
>> > compiling with EXTRA_CFLAGS=-W:
>> > make V=1 EXTRA_CFLAGS=-W ARCH=arm s3c2410_defconfig
>> > make V=1 EXTRA_CFLAGS=-W ARCH=arm menuconfig
>> > set 'arm-linux-gnu-' for cross chain prefix
>> > make V=1 EXTRA_CFLAGS=-W ARCH=arm
>> >
>> > it will report:
>> > kernel/posix-cpu-timers.c:1065:19: warning: �now� may be used uninitialized in this function [-Wuninitialized]
>> >
>> > it seems it is really a bug.
>> > can any member help to fix it ?
>> > or provide additional suggestion ?
>> > (it seems only "unsigned long long now = 0" is not enough).
> Yeah it's missing a call to cpu_timer_sample_group() before
> clear_dead_task(). Andrew Morton reported the warning and I have a
> pending patch to fix that. I'm just checking a few other things before
> sending it. These clear_dead_task() calls seem to also conflict with
> cleanup_timers(). I'm fixing that too.
>
> Thanks for your report!
>
>
thank you, too.
:-)
--
Chen Gang
Asianux Corporation
prev parent reply other threads:[~2013-03-26 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 6:36 [Suggestion] kernel: 'now' may be used uninitialized in posix_cpu_timer_schedule function Chen Gang
2013-03-26 6:41 ` Chen Gang
2013-03-26 12:27 ` Frederic Weisbecker
2013-03-26 12:32 ` Chen Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51519549.5070204@asianux.com \
--to=gang.chen@asianux.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox