public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Danny Baumann <dannybaumann@web.de>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	David Airlie <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/i915: Allow specifying a minimum brightness level for sysfs control.
Date: Tue, 26 Mar 2013 18:04:37 +0100	[thread overview]
Message-ID: <5151D525.3040807@web.de> (raw)
In-Reply-To: <20130326152029.GA993@cantiga.alporthouse.com>

Hi,

>> Thus far our assumption always was that the acpi backlight works better
>> than the intel native backlight. So everything only uses the intel
>> backlight if there's no other backlight driver by default.
>
> There are machines, such as the pnv netbook on my desk, on which
> intel_backlight does nothing and the only control is through
> acpi_backlight0.

That's fine - but on my machine, (at least currently) it's the other way 
around. acpi_video[0|1] do nothing, while intel_backlight is the only 
method that works. This sucks (please also see my reply to Daniel), but 
it's a fact.

> Generalising expected behaviour based on one firmware
> implementation is fraught with danger.

I'm not sure what you mean here. I interpret the statement as 'user 
space should treat acpi_videoX and intel_backlight differently'. Is this 
interpretation correct?
If so, how is user space supposed to know how the respective backlight 
device will behave, as this behaviour might change at any point in time 
if there's no understanding in how it _should_ behave? What currently 
happens on my machine is that KDE completely turns off the backlight 
after the dim timeout, because it assumes that the value 0 will keep the 
backlight at a readable level (which would be the case if it used 
acpi_videoX because this behaviour is mandated by the spec there). I 
first thought of sending a patch to KDE, but I couldn't figure out how 
KDE is _supposed_ to correctly handle the situation, especially given 
that the actual sysfs interface used is abstracted away by Xrandr (and 
chosen by the Intel Xorg driver). With my patch, intel_backlight behaves 
in a way that roughly matches the behaviour mandated by the ACPI spec.
Do you have a way in mind that allows fixing this in user space?

Thanks,

Danny

  reply	other threads:[~2013-03-26 17:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 11:48 [PATCH 0/1] drm/i915: Allow specifying a minimum brightness level for sysfs control Danny Baumann
2013-03-26 11:48 ` [PATCH 1/1] " Danny Baumann
2013-03-26 15:13   ` Daniel Vetter
2013-03-26 15:20     ` Chris Wilson
2013-03-26 17:04       ` Danny Baumann [this message]
2013-03-26 16:55     ` Danny Baumann
2013-03-26 17:02 ` [PATCH 0/1] " Matthew Garrett
2013-03-26 17:10   ` Danny Baumann
2013-03-26 17:21     ` Matthew Garrett
2013-03-27 11:56       ` Danny Baumann
2013-03-27 12:35         ` Alex Deucher
2013-03-27 12:56           ` Danny Baumann
2013-03-27 13:06             ` Alex Deucher
2013-03-27 15:10         ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5151D525.3040807@web.de \
    --to=dannybaumann@web.de \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox