From: Stephen Warren <swarren@wwwdotorg.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-kernel@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] hw_random: Add Broadcom BCM2835 RNG Driver
Date: Tue, 26 Mar 2013 20:52:02 -0600 [thread overview]
Message-ID: <51525ED2.80109@wwwdotorg.org> (raw)
In-Reply-To: <1364135825.2906.14.camel@hobbes.kokotovo>
On 03/24/2013 08:37 AM, Lubomir Rintel wrote:
> On Fri, 2013-03-22 at 20:44 -0600, Stephen Warren wrote:
>
> Thank you for your response!
>
>> On 03/22/2013 06:55 AM, Lubomir Rintel wrote:
>>> Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
>>
>> A commit description would be useful.
>>
>>> arch/arm/boot/dts/bcm2835.dtsi | 5 +
>>> arch/arm/configs/bcm2835_defconfig | 3 +-
>>> drivers/char/hw_random/Kconfig | 12 +++
>>> drivers/char/hw_random/Makefile | 1 +
>>> drivers/char/hw_random/bcm2835-rng.c | 137 ++++++++++++++++++++++++++++++++++
>>
>> This should be split into 3 separate patches: (1) The driver itself, (2)
>> the change to bcm2835.dtsi, and (3) the change to bcm2835_defconfig.
>>
>> Since you're adding a new device to device tree for the first time, you
>> should write a binding document for it; most likely
>> Documentation/devicetree/bindings/rng/brcm,bcm2835.txt (or perhaps
>> /random/ rather than /rng/?)
>
> Okay. I'm tempted to stick to "rng" instead of "random" as it seems more
> consistent to me, but I don't have a strong reason to back it with. What would
> be a good reason for using "random"?
I figured that "random" might be more meaningful/understandable for some
people. It's not a big deal either way though.
next prev parent reply other threads:[~2013-03-27 2:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 12:55 [PATCH] hw_random: Add Broadcom BCM2835 RNG Driver Lubomir Rintel
2013-03-23 2:44 ` Stephen Warren
2013-03-24 14:37 ` Lubomir Rintel
2013-03-27 2:52 ` Stephen Warren [this message]
2013-03-28 6:15 ` Lubomir Rintel
2013-03-24 14:31 ` [PATCH v2] bcm2835: Add Broadcom BCM2835 RNG to the device tree Lubomir Rintel
2013-03-24 14:39 ` [PATCH v2] hw_random: Add Broadcom BCM2835 RNG driver Lubomir Rintel
2013-03-24 14:41 ` [PATCH v2] arm: Add Broadcom BCM2835 RNG driver to bcm2835_defconfig Lubomir Rintel
2013-04-03 6:28 ` Stephen Warren
2013-03-27 3:00 ` [PATCH v2] hw_random: Add Broadcom BCM2835 RNG driver Stephen Warren
2013-03-27 3:20 ` Stephen Warren
2013-03-28 6:19 ` [PATCH v3] " Lubomir Rintel
2013-04-03 1:53 ` Herbert Xu
2013-03-27 2:55 ` [PATCH v2] bcm2835: Add Broadcom BCM2835 RNG to the device tree Stephen Warren
2013-03-28 6:12 ` [PATCH] " Lubomir Rintel
2013-04-02 2:38 ` Stephen Warren
2013-04-03 6:28 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51525ED2.80109@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkundrak@v3.sk \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox