From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756975AbcH2KrC (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Aug 2016 06:47:02 -0400
Received: from mout.kundenserver.de ([212.227.126.134]:50187 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756777AbcH2Kq7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Aug 2016 06:46:59 -0400
From: Arnd Bergmann <arnd@linaro.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: bskeggs@redhat.com, airlied@linux.ie, dri-devel@lists.freedesktop.org,
        nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        xie.baoyou@zte.com.cn
Subject: Re: [PATCH] fix:overlay: add missing header dependencies
Date: Mon, 29 Aug 2016 12:41:18 +0200
Message-ID: <5154334.AoCXYPCTSK@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1472360572-28375-1-git-send-email-baoyou.xie@linaro.org>
References: <1472360572-28375-1-git-send-email-baoyou.xie@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:IN1ZKbaq1vCVx26FcBS5EGVq3lqIbmIyHAlZ5zL7a8IyU/y8KHd
 UlSi50UPQF0THg6YePpW70fELWpGjccEB9KfkSuZGr3VtBUFDNgi0d5JHxryvt3Q41FbCMw
 8iyaB1fyO07YYignkYtHsSLGUVA+dP9ZrKrky2UlyVrdSUXBE3xa0wzgjL62lPBiiGWGCCm
 GLntGKDUV/ltWehkq+/TA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:+/sKvMhand4=:Cg15xyFV/p+Um95QtnYGO3
 Rd1KYwhpKz5dycbzTUMHXRSRu5Evsl1jqVnf7NSeSh1DqRmaunQhwLq+qUnY30pz0rxnVM5CQ
 7yrkkcIMnbvxbBP2uXbD5XeNRPTLL4vhV+bVLJ5DYsngRG94pJ+qRvbOk8QMFDUfnXcyNTBsM
 VPIMyD+nFvi6ANqIR3fJ2AXTRNSD4wCftsG+GoS0g1d6MrNfHt/cvVVciQ/zo/LQzRJFukfF4
 FMrhSVXgs0t9ywhfsQK7d24iDDgNLUK6r19CGSkA6QcwE79Y/4SycfyhZescLrZwmFwxdU4x2
 89/r/szQCRukzzddF/ZKxCPW2AE4uxBt8QYTI01Tw2lG7Ior4ehoIL+0MyZPFxenMPdzvaebz
 16Zlc3YxqypbH3Fa50JAfeDiGYbszjqGOT1g++mGUm+zkca4SUz7IttMXCfdY3L3WDd+Oun5C
 kBzrE5vsmMdDao6ySWeae7KO36iwrPm2jA1psZnfHbymiAzxRdqmVyUc89YE1b8xHYI9+FB4z
 /xiLc4Gu9yNpKrAPsOJW869nvLVfPRbsyszMlU9JKAzWlrU9T2Fs/ikt6yFpzhrSZNzysvO1n
 qpJcp5yI+KOaTEPEu92VFUm2nw+VayAXeH2nkyHEXiFCFdEB7rcTuEBVd/xhxRTuuoPuGPNxn
 6vtfp7HuodlmkxR430O146Ln+cVVOqDQhJxG5NrvJ4vcz4jniZbqilznAHZkSgs+hNZaQPNgg
 4FHBZPmT6WQaOvwJ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, August 28, 2016 1:02:52 PM CEST Baoyou Xie wrote:
> We get 1 warning when build kernel with W=1:
> drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes]
> 
> In fact, this function is declared in disp.h, so this patch
> add missing header dependencies
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

a few general notes:

- please use my arnd@arndb.de address on patch submissions, not the linaro
  address.

- for the email subject lines, have a look at what the typical style
  is for the file. "overlay:" is not a good name here because it's not
  unique to the driver, so better use "drm/nouveau", which will also
  get the attention of the right people.

- please drop the "fix:" prefix in the subject.

	Arnd