From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: linux-fbdev@vger.kernel.org, linux-doc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shawn Guo <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] video: ssd1307fb: Add support for SSD1306 OLED controller
Date: Fri, 29 Mar 2013 20:34:19 +0100 [thread overview]
Message-ID: <5155ECBB.9000008@free-electrons.com> (raw)
In-Reply-To: <20130329183842.GH20693@game.jcrosoft.org>
Hi Jean Christophe,
Le 29/03/2013 19:38, Jean-Christophe PLAGNIOL-VILLARD a écrit :
> On 17:44 Wed 06 Mar , Maxime Ripard wrote:
[snip]
>> static int ssd1307fb_probe(struct i2c_client *client,
>> const struct i2c_device_id *id)
>> {
>> struct fb_info *info;
>> - u32 vmem_size = SSD1307FB_WIDTH * SSD1307FB_HEIGHT / 8;
>> + struct device_node *node = client->dev.of_node;
>> + u32 vmem_size;
>> struct ssd1307fb_par *par;
>> u8 *vmem;
>> int ret;
>>
>> - if (!client->dev.of_node) {
>> + if (!node) {
> why this will be DT only?
>
> a platform or ARN that does not support DT can not use this driver
>
> this looks not right
Because the platform I was developing that for was DT-only, and I guess
if someone wants to use this driver on a non-DT platform, that
hypothetical someone can always send a patch to enable the "old-style"
probing in this driver.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-03-29 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1362588251-1824-1-git-send-email-maxime.ripard@free-electrons.com>
2013-03-06 16:44 ` [PATCH 1/2] video: ssd1307fb: Add support for SSD1306 OLED controller Maxime Ripard
2013-03-29 18:38 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-29 19:34 ` Maxime Ripard [this message]
2013-03-06 16:44 ` [PATCH 2/2] ARM: dts: cfa10036: Change the OLED display to SSD1306 Maxime Ripard
[not found] <1365753603-4438-1-git-send-email-maxime.ripard@free-electrons.com>
2013-04-12 8:00 ` [PATCH 1/2] video: ssd1307fb: Add support for SSD1306 OLED controller Maxime Ripard
[not found] <1366624555-5616-1-git-send-email-maxime.ripard@free-electrons.com>
2013-04-22 9:55 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5155ECBB.9000008@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=FlorianSchandinat@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox