public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: do not exit in main process subroutine
Date: Sat, 30 Mar 2013 18:30:38 +0800	[thread overview]
Message-ID: <5156BECE.9070701@huawei.com> (raw)
In-Reply-To: <5153BC45.807@huawei.com>

On 2013/3/28 11:43, zhangwei(Jovi) wrote:
> Currently checkpatch program exit when process empty file,
> This will cause issue when @ARGV include many files ready to check.
> 
> For example, there may have Module.symvers empty file in kernel directory.
> 
> [root@jovi ~]# scripts/checkpatch.pl -f kernel/*
> 
> then many file "after" empty file will not be check by script.
> so disallow exit in main process subroutine.
> 
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
Joe, Ping?

> ---
>  scripts/checkpatch.pl |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b28cc38..6924733 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3634,19 +3634,19 @@ sub process {
>  	# If we have no input at all, then there is nothing to report on
>  	# so just keep quiet.
>  	if ($#rawlines == -1) {
> -		exit(0);
> +		return $clean;
>  	}
> 
>  	# In mailback mode only produce a report in the negative, for
>  	# things that appear to be patches.
>  	if ($mailback && ($clean == 1 || !$is_patch)) {
> -		exit(0);
> +		return $clean;
>  	}
> 
>  	# This is not a patch, and we are are in 'no-patch' mode so
>  	# just keep quiet.
>  	if (!$chk_patch && !$is_patch) {
> -		exit(0);
> +		return $clean;
>  	}
> 
>  	if (!$is_patch) {
> 



  reply	other threads:[~2013-03-30 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28  3:43 [PATCH] checkpatch: do not exit in main process subroutine zhangwei(Jovi)
2013-03-30 10:30 ` zhangwei(Jovi) [this message]
2013-03-31  4:30   ` Joe Perches
2013-04-01  3:55   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5156BECE.9070701@huawei.com \
    --to=jovi.zhangwei@huawei.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox