* [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET @ 2013-04-01 4:43 Guenter Roeck 2013-04-01 16:11 ` Randy Dunlap 2013-04-01 19:29 ` Greg Kroah-Hartman 0 siblings, 2 replies; 7+ messages in thread From: Guenter Roeck @ 2013-04-01 4:43 UTC (permalink / raw) To: linux-kernel Cc: Andy King, Greg Kroah-Hartman, Dmitry Torokhov, Guenter Roeck Fix: ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! Both functions are defined in the core networking code. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/misc/vmw_vmci/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/vmw_vmci/Kconfig b/drivers/misc/vmw_vmci/Kconfig index 39c2eca..ea98f7e 100644 --- a/drivers/misc/vmw_vmci/Kconfig +++ b/drivers/misc/vmw_vmci/Kconfig @@ -4,7 +4,7 @@ config VMWARE_VMCI tristate "VMware VMCI Driver" - depends on X86 && PCI + depends on X86 && PCI && NET help This is VMware's Virtual Machine Communication Interface. It enables high-speed communication between host and guest in a virtual -- 1.7.9.7 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET 2013-04-01 4:43 [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET Guenter Roeck @ 2013-04-01 16:11 ` Randy Dunlap 2013-04-01 19:29 ` Greg Kroah-Hartman 1 sibling, 0 replies; 7+ messages in thread From: Randy Dunlap @ 2013-04-01 16:11 UTC (permalink / raw) To: Guenter Roeck Cc: linux-kernel, Andy King, Greg Kroah-Hartman, Dmitry Torokhov On 03/31/13 21:43, Guenter Roeck wrote: > Fix: > > ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > > Both functions are defined in the core networking code. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > drivers/misc/vmw_vmci/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/vmw_vmci/Kconfig b/drivers/misc/vmw_vmci/Kconfig > index 39c2eca..ea98f7e 100644 > --- a/drivers/misc/vmw_vmci/Kconfig > +++ b/drivers/misc/vmw_vmci/Kconfig > @@ -4,7 +4,7 @@ > > config VMWARE_VMCI > tristate "VMware VMCI Driver" > - depends on X86 && PCI > + depends on X86 && PCI && NET > help > This is VMware's Virtual Machine Communication Interface. It enables > high-speed communication between host and guest in a virtual > -- ~Randy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET 2013-04-01 4:43 [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET Guenter Roeck 2013-04-01 16:11 ` Randy Dunlap @ 2013-04-01 19:29 ` Greg Kroah-Hartman 2013-04-01 20:02 ` Guenter Roeck 1 sibling, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2013-04-01 19:29 UTC (permalink / raw) To: Guenter Roeck; +Cc: linux-kernel, Andy King, Dmitry Torokhov On Sun, Mar 31, 2013 at 09:43:59PM -0700, Guenter Roeck wrote: > Fix: > > ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > > Both functions are defined in the core networking code. This is already in linux-next, thanks. greg k-h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET 2013-04-01 19:29 ` Greg Kroah-Hartman @ 2013-04-01 20:02 ` Guenter Roeck 2013-04-01 20:11 ` Greg Kroah-Hartman 0 siblings, 1 reply; 7+ messages in thread From: Guenter Roeck @ 2013-04-01 20:02 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-kernel, Andy King, Dmitry Torokhov On Mon, Apr 01, 2013 at 12:29:39PM -0700, Greg Kroah-Hartman wrote: > On Sun, Mar 31, 2013 at 09:43:59PM -0700, Guenter Roeck wrote: > > Fix: > > > > ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > > ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > > > > Both functions are defined in the core networking code. > > This is already in linux-next, thanks. > Uuh ... and I submitted it. Sorry for the noise. Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary nightly build errors for me. Thanks, Guenter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET 2013-04-01 20:02 ` Guenter Roeck @ 2013-04-01 20:11 ` Greg Kroah-Hartman 2013-04-01 22:17 ` Guenter Roeck 0 siblings, 1 reply; 7+ messages in thread From: Greg Kroah-Hartman @ 2013-04-01 20:11 UTC (permalink / raw) To: Guenter Roeck; +Cc: linux-kernel, Andy King, Dmitry Torokhov On Mon, Apr 01, 2013 at 01:02:35PM -0700, Guenter Roeck wrote: > On Mon, Apr 01, 2013 at 12:29:39PM -0700, Greg Kroah-Hartman wrote: > > On Sun, Mar 31, 2013 at 09:43:59PM -0700, Guenter Roeck wrote: > > > Fix: > > > > > > ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > > > ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > > > > > > Both functions are defined in the core networking code. > > > > This is already in linux-next, thanks. > > > Uuh ... and I submitted it. Sorry for the noise. > > Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary > nightly build errors for me. As it's a configuration that no "real" user would ever hit, it's not really 3.9 material, sorry. greg k0h ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET 2013-04-01 20:11 ` Greg Kroah-Hartman @ 2013-04-01 22:17 ` Guenter Roeck 2013-04-01 21:53 ` Randy Dunlap 0 siblings, 1 reply; 7+ messages in thread From: Guenter Roeck @ 2013-04-01 22:17 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: linux-kernel, Andy King, Dmitry Torokhov On Mon, Apr 01, 2013 at 01:11:52PM -0700, Greg Kroah-Hartman wrote: > On Mon, Apr 01, 2013 at 01:02:35PM -0700, Guenter Roeck wrote: > > On Mon, Apr 01, 2013 at 12:29:39PM -0700, Greg Kroah-Hartman wrote: > > > On Sun, Mar 31, 2013 at 09:43:59PM -0700, Guenter Roeck wrote: > > > > Fix: > > > > > > > > ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > > > > ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! > > > > > > > > Both functions are defined in the core networking code. > > > > > > This is already in linux-next, thanks. > > > > > Uuh ... and I submitted it. Sorry for the noise. > > > > Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary > > nightly build errors for me. > > As it's a configuration that no "real" user would ever hit, it's not > really 3.9 material, sorry. > Fair enough. On the other side, value of "make randconfig" has been reduced significantly compared to earlier times, when patches like this tended to be accepted into release candidates. Until a few releases ago, "make randconfig" usually passed at least for main targets by the time a kernel was relased. With this no longer the case, fewer and fewer people will look into nightly or per-rc build results and provide patches. This in turn will likely reduce reliability, as real problems are more and more hidden among all the "unreal" build errors. In addition to that, more and more people will end up with non-buildable configurations and have to spend time trying to figure out why exactly a build failed. But maybe this is all my imagination, so feel free to just ignore my ranting ;). Guenter ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET 2013-04-01 22:17 ` Guenter Roeck @ 2013-04-01 21:53 ` Randy Dunlap 0 siblings, 0 replies; 7+ messages in thread From: Randy Dunlap @ 2013-04-01 21:53 UTC (permalink / raw) To: Guenter Roeck Cc: Greg Kroah-Hartman, linux-kernel, Andy King, Dmitry Torokhov On 04/01/13 15:17, Guenter Roeck wrote: > On Mon, Apr 01, 2013 at 01:11:52PM -0700, Greg Kroah-Hartman wrote: >> On Mon, Apr 01, 2013 at 01:02:35PM -0700, Guenter Roeck wrote: >>> On Mon, Apr 01, 2013 at 12:29:39PM -0700, Greg Kroah-Hartman wrote: >>>> On Sun, Mar 31, 2013 at 09:43:59PM -0700, Guenter Roeck wrote: >>>>> Fix: >>>>> >>>>> ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! >>>>> ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! >>>>> >>>>> Both functions are defined in the core networking code. >>>> >>>> This is already in linux-next, thanks. >>>> >>> Uuh ... and I submitted it. Sorry for the noise. >>> >>> Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary >>> nightly build errors for me. >> >> As it's a configuration that no "real" user would ever hit, it's not >> really 3.9 material, sorry. >> > Fair enough. > > On the other side, value of "make randconfig" has been reduced significantly > compared to earlier times, when patches like this tended to be accepted into > release candidates. Until a few releases ago, "make randconfig" usually passed > at least for main targets by the time a kernel was relased. With this no longer > the case, fewer and fewer people will look into nightly or per-rc build results > and provide patches. This in turn will likely reduce reliability, as real > problems are more and more hidden among all the "unreal" build errors. > In addition to that, more and more people will end up with non-buildable > configurations and have to spend time trying to figure out why exactly > a build failed. > > But maybe this is all my imagination, so feel free to just ignore my ranting ;). My experiences have been that Linus is not opposed to taking such build fixes at almost any time. IOW, I think that Greg is being more strict than Linus would be, but Greg is the misc/ maintainer, so it's his call. -- ~Randy ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-04-01 22:53 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-04-01 4:43 [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET Guenter Roeck 2013-04-01 16:11 ` Randy Dunlap 2013-04-01 19:29 ` Greg Kroah-Hartman 2013-04-01 20:02 ` Guenter Roeck 2013-04-01 20:11 ` Greg Kroah-Hartman 2013-04-01 22:17 ` Guenter Roeck 2013-04-01 21:53 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox